Repository navigation
test(relay): check Run's error in the peers test - #58
Merged
Merged
Conversation
golangci-lint 2.15's errcheck flags a bare receive from a chan error. The sibling test already asserts context.Canceled; this one now does too, which unblocks the golangci-lint 2.15.0 update in #47.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Rollout risk: none. Test-only change.
Manual step after merge: none. Renovate rebases #47 and its Go job should go green.
golangci-lint 2.15.0 (Renovate #47) reports
internal/hubble/relay/client_test.go:199:2: Error return value is not checked (errcheck)on a bare<-done, wheredoneis achan error. The test now assertscontext.Canceled, exactly as the sibling test at line 153 does.Verified locally:
go test ./internal/hubble/relay/passes, andgolangci-lint run ./...with 2.15.0 reports 0 issues.