Adds a showFeedback property to the QrReader#218
Open
howech wants to merge 4 commits intoJodusNodus:masterfrom
Open
Adds a showFeedback property to the QrReader#218howech wants to merge 4 commits intoJodusNodus:masterfrom
howech wants to merge 4 commits intoJodusNodus:masterfrom
Conversation
When the `showFeedback` option is included in QrReader control, it will hilight the detected qr code in the video feed. This is accomplished by drawing a div over the top of the feed, which is positioned such that it approximately bounds the detected qr code.
Added an option to include some visual feedback for scanned qr codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #217
With this PR, the QrReader accepts a
showFeedbackproperty. When present, the control will display a green box around the detected QR code.