Skip to content

fix: handle constant ConstantOrCache with Enzyme and SCT#753

Merged
gdalle merged 2 commits intomainfrom
gd/enz_constantorcache
Mar 20, 2025
Merged

fix: handle constant ConstantOrCache with Enzyme and SCT#753
gdalle merged 2 commits intomainfrom
gd/enz_constantorcache

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Mar 20, 2025

  • For Enzyme: Automatically detect activity of ConstantOrCache and annotate it as Const or Duplicated (never Active) accordingly
  • For SCT: Add translation utility for ConstantOrCache
  • Simplify context types

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (cfab84d) to head (6de1319).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   97.87%   96.97%   -0.90%     
==========================================
  Files         128      124       -4     
  Lines        7423     7409      -14     
==========================================
- Hits         7265     7185      -80     
- Misses        158      224      +66     
Flag Coverage Δ
DI 97.76% <100.00%> (-1.18%) ⬇️
DIT 95.01% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as draft March 20, 2025 19:15
@gdalle gdalle changed the title fix: handle constant ConstantOrCache with Enzyme fix: handle constant ConstantOrCache with Enzyme and SCT Mar 20, 2025
@gdalle gdalle added the skipci Don't run CI tests and docs label Mar 20, 2025
@gdalle gdalle marked this pull request as ready for review March 20, 2025 20:03
@gdalle gdalle merged commit a059e19 into main Mar 20, 2025
26 of 27 checks passed
@gdalle gdalle deleted the gd/enz_constantorcache branch May 12, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skipci Don't run CI tests and docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant