Skip to content

perf: remove Mooncake warmup during preparation #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdalle merged 2 commits into from
Apr 10, 2025
Merged

perf: remove Mooncake warmup during preparation #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb74d52
perf: remove Mooncake warmup during preparation
gdalle Apr 10, 2025
eadb50e
Bump
gdalle Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DifferentiationInterface/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DifferentiationInterface"
uuid = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
authors = ["Guillaume Dalle", "Adrian Hill"]
version = "0.6.50"
version = "0.6.51"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down
4 changes: 1 addition & 3 deletions DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
y = f(x, map(DI.unwrap, contexts)...)
dy_righttype = zero_tangent(y)
prep = MooncakeOneArgPullbackPrep(_sig, cache, dy_righttype)
DI.value_and_pullback(f, prep, backend, x, ty, contexts...)
return prep
end

Expand Down Expand Up @@ -111,11 +110,10 @@
) where {F,C}
_sig = DI.signature(f, backend, x, contexts...; strict)
config = get_config(backend)
cache = prepare_pullback_cache(
cache = prepare_gradient_cache(

Check warning on line 113 in DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl

View check run for this annotation

Codecov / codecov/patch

DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/onearg.jl#L113 

Added line #L113 was not covered by tests
f, x, map(DI.unwrap, contexts)...; config.debug_mode, config.silence_debug_messages
)
prep = MooncakeGradientPrep(_sig, cache)
DI.value_and_gradient(f, prep, backend, x, contexts...)
return prep
end

Expand Down
1 change: 0 additions & 1 deletion DifferentiationInterface/ext/DifferentiationInterfaceMooncakeExt/twoarg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ function DI.prepare_pullback_nokwarg(
)
dy_righttype_after = zero_tangent(y)
prep = MooncakeTwoArgPullbackPrep(_sig, cache, dy_righttype_after, target_function)
DI.value_and_pullback(f!, y, prep, backend, x, ty, contexts...)
return prep
end

Expand Down