Skip to content

fix: speed up sparse preparation for GPU arrays #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdalle merged 2 commits into from
Jul 9, 2025
Merged

fix: speed up sparse preparation for GPU arrays #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c30c589
fix: speed up sparse preparation for GPU arrays
gdalle Jul 7, 2025
e86b280
Remove conditional GPU tests
gdalle Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
steps:
- label: "DI GPU tests"
if: build.pull_request.labels includes "gpu"
plugins:
- JuliaCI/julia#v1:
version: "1"
Expand Down
10 changes: 9 additions & 1 deletion DifferentiationInterface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [0.7.2]

### Feat

- Backend switching for Mooncake ([#768])

### Fixed

- Speed up sparse preparation for GPU arrays ([#818])

## [0.7.1]

### Feat
Expand Down Expand Up @@ -42,12 +48,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Allocate Enzyme shadow memory during preparation ([#782])

[unreleased]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.7.1...main
[unreleased]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.7.2...main
[0.7.2]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.7.1...DifferentiationInterface-v0.7.2
[0.7.1]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.7.0...DifferentiationInterface-v0.7.1
[0.7.0]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.6.54...DifferentiationInterface-v0.7.0
[0.6.54]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.6.53...DifferentiationInterface-v0.6.54
[0.6.53]: https://github.com/JuliaDiff/DifferentiationInterface.jl/compare/DifferentiationInterface-v0.6.52...DifferentiationInterface-v0.6.53

[#818]: https://github.com/JuliaDiff/DifferentiationInterface.jl/pull/818
[#812]: https://github.com/JuliaDiff/DifferentiationInterface.jl/pull/812
[#810]: https://github.com/JuliaDiff/DifferentiationInterface.jl/pull/810
[#809]: https://github.com/JuliaDiff/DifferentiationInterface.jl/pull/809
Expand Down
6 changes: 4 additions & 2 deletions DifferentiationInterface/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "DifferentiationInterface"
uuid = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
authors = ["Guillaume Dalle", "Adrian Hill"]
version = "0.7.1"
version = "0.7.2"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down Expand Up @@ -42,7 +42,9 @@ DifferentiationInterfaceGPUArraysCoreExt = "GPUArraysCore"
DifferentiationInterfaceGTPSAExt = "GTPSA"
DifferentiationInterfaceMooncakeExt = "Mooncake"
DifferentiationInterfacePolyesterForwardDiffExt = [
"PolyesterForwardDiff", "ForwardDiff", "DiffResults"
"PolyesterForwardDiff",
"ForwardDiff",
"DiffResults",
]
DifferentiationInterfaceReverseDiffExt = ["ReverseDiff", "DiffResults"]
DifferentiationInterfaceSparseArraysExt = "SparseArrays"
Expand Down
4 changes: 1 addition & 3 deletions .../ext/DifferentiationInterfaceGPUArraysCoreExt/DifferentiationInterfaceGPUArraysCoreExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ end
function DI.multibasis(a::AbstractGPUArray{T}, inds) where {T}
b = similar(a)
fill!(b, zero(T))
for i in inds
@allowscalar b[i] = one(T)
end
view(b, inds) .= one(T)
return b
end

Expand Down
Loading