Skip to content

fix: replace one with oneunit for basis computation#826

Merged
gdalle merged 4 commits intomainfrom
gd/one
Aug 1, 2025
Merged

fix: replace one with oneunit for basis computation#826
gdalle merged 4 commits intomainfrom
gd/one

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Jul 31, 2025

For unitful quantities, the right way to construct a basis or initialize a derivative / gradient is with oneunit(T) instead of one(T) (the latter is just a multiplicative identity).

Fixes JuliaGeometry/MeshIntegrals.jl#191

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (ea73473) to head (6803e2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   97.88%   97.89%   +0.01%     
==========================================
  Files         129      129              
  Lines        7752     7751       -1     
==========================================
  Hits         7588     7588              
+ Misses        164      163       -1     
Flag Coverage Δ
DI 98.73% <100.00%> (ø)
DIT 95.66% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review July 31, 2025 17:22
@gdalle gdalle added the skipci Don't run CI tests and docs label Aug 1, 2025
@gdalle gdalle merged commit dae09ef into main Aug 1, 2025
47 of 48 checks passed
@gdalle gdalle deleted the gd/one branch August 1, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skipci Don't run CI tests and docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for use of Mooncake.jl AD differentials

1 participant