Skip to content

Support ADTypes.NoAutoDiff#851

Merged
gdalle merged 3 commits intoJuliaDiff:mainfrom
oschulz:no-auto-diff
Sep 22, 2025
Merged

Support ADTypes.NoAutoDiff#851
gdalle merged 3 commits intoJuliaDiff:mainfrom
oschulz:no-auto-diff

Conversation

@oschulz
Copy link
Copy Markdown
Contributor

@oschulz oschulz commented Sep 12, 2025

@oschulz oschulz requested a review from gdalle as a code owner September 12, 2025 13:30
@oschulz oschulz mentioned this pull request Sep 12, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.10%. Comparing base (c19f07d) to head (8c13b66).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         134      134           
  Lines        7986     7988    +2     
=======================================
+ Hits         7835     7837    +2     
  Misses        151      151
Flag Coverage Δ
DI 98.79% <100.00%> (+<0.01%) ⬆️
DIT 96.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz oschulz force-pushed the no-auto-diff branch 2 times, most recently from 95ba522 to 7e44a45 Compare September 12, 2025 15:17
@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Sep 13, 2025

@gdalle is this Ok like this?

@gdalle gdalle mentioned this pull request Sep 18, 2025
Merged
@gdalle
Copy link
Copy Markdown
Member

gdalle commented Sep 18, 2025

I fixed the Enzyme CI error, can you integrate the latest changes from main and bump the compat for ADTypes appropriately?

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Sep 18, 2025

I fixed the Enzyme CI error, can you integrate the latest changes from main and bump the compat for ADTypes appropriately?

Done now - is this Ok?

@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Sep 18, 2025

Test failures are unrelated, right?

gdalle
gdalle requested changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can just take my small nitpick into account and fill the changelog, we're good to go!

Comment thread DifferentiationInterface/src/utils/check.jl Outdated
@oschulz
Copy link
Copy Markdown
Contributor Author

oschulz commented Sep 22, 2025

If you can just take my small nitpick into account and fill the changelog, we're good to go!

Done - good like this?

gdalle
gdalle approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gdalle gdalle merged commit f8ffd05 into JuliaDiff:main Sep 22, 2025
70 of 71 checks passed
@oschulz oschulz deleted the no-auto-diff branch September 22, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdalle gdalle gdalle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oschulz @gdalle