feat: allow non-numeric arguments with AutoSymbolics#945
feat: allow non-numeric arguments with AutoSymbolics#945gdalle merged 2 commits intoJuliaDiff:mainfrom
AutoSymbolics#945Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
- Coverage 98.23% 98.21% -0.02%
==========================================
Files 133 133
Lines 7968 7976 +8
==========================================
+ Hits 7827 7834 +7
- Misses 141 142 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I don't think the Enzyme failures is due to this PR. Not sure what the errors mean. |
|
It means Enzyme broke again ^^ not on you |
|
Would it be possible to merge and tag this soon? I have a chain of PRs depending on it 😅 |
|
I'm on vacation but I'll review today |
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
LGTM, I just replaced "dummy" with a less offensive term. If the tests pass, I'll merge and release
|
I didn't know you were on vacation. Thanks for reviewing nonetheless! And I'll take a look at inclusiveness reference, thanks for the fix. |
|
The Enzyme failure is EnzymeAD/Enzyme.jl#2854 |
2 participants
This allows DI to handle functions accepting non-numeric arguments with
AutoSymbolicsif they are "sufficiently nice". Typically this means that they only pass the non-numeric arguments to registered functions, or use the incoming support for symbolic structs in JuliaSymbolics/Symbolics.jl#1707.