Skip to content

fix!: turn Chairmarks and JET into weakdeps#958

Merged
gdalle merged 12 commits intomainfrom
gd/ditdeps
Jan 28, 2026
Merged

fix!: turn Chairmarks and JET into weakdeps#958
gdalle merged 12 commits intomainfrom
gd/ditdeps

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Jan 26, 2026

Warning

Breaking changes:

  • Move benchmarking and type stability testing to package extensions: they now require Chairmarks / JET to be loaded manually
  • Change output type of benchmarking to a Tables.jl-compatible object, which requires manual conversion to DataFrame for analysis

Rationale:

  • JET causes terrible compatibility conflicts
  • Chairmarks is not MIT-licensed
  • DataFrames is a heavy dep

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.21%. Comparing base (8d33550) to head (4981006).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   98.20%   98.21%           
=======================================
  Files         133      135    +2     
  Lines        7983     8002   +19     
=======================================
+ Hits         7840     7859   +19     
  Misses        143      143           
Flag Coverage Δ
DI 98.97% <ø> (ø)
DIT 96.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gdalle gdalle marked this pull request as ready for review January 28, 2026 12:24
@gdalle gdalle merged commit a266e80 into main Jan 28, 2026
69 of 70 checks passed
@gdalle gdalle deleted the gd/ditdeps branch January 28, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant