Skip to content

Add a cconvert for each unsafe_convert #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhz2 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a cconvert for each unsafe_convert #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92b7d01
Add a cconvert for each unsafe_convert
nhz2 Jan 28, 2026
a20d543
fix spacing
nhz2 Jan 28, 2026
4fb1602
test on nightly
nhz2 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- 'min'
- 'lts'
- '1'
- 'nightly'
os:
- ubuntu-latest
- macOS-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/downstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
julia-version: ['1']
julia-version: ['1', 'nightly']
os: [ubuntu-latest]
package:
- {repo: ApproxFunBase.jl, group: JuliaApproximation}
Expand Down
3 changes: 3 additions & 0 deletions src/BlockSkylineMatrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ _parent_blocks(V::BlockBandedBlock)::Tuple{Int,Int} =
MemoryLayout(::Type{<:BlockBandedBlock}) = ColumnMajor()
Base.elsize(::Type{<:BlockSkylineMatrix{T,R}}) where {T,R} = Base.elsize(R)

function Base.cconvert(::Type{Ptr{T}}, V::BlockBandedBlock{T}) where T
V
end
function Base.unsafe_convert(::Type{Ptr{T}}, V::BlockBandedBlock{T}) where T
A = parent(V)
K,J = _parent_blocks(V)
Expand Down
9 changes: 9 additions & 0 deletions src/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ strides(V::SubBlockSkylineMatrix{<:Any,LL,UU,<:Union{BlockRange1,Block1},Block1}
(1,parent(V).block_sizes.block_strides[Int(parentindices(V)[2].block)])


function Base.cconvert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,<:Union{BlockRange1,Block1},Block1}) where {T,LL,UU}
V
end
function unsafe_convert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,<:Union{BlockRange1,Block1},Block1}) where {T,LL,UU}
A = parent(V)
JR = parentindices(V)[2]
Expand All @@ -117,6 +120,9 @@ end
strides(V::SubBlockSkylineMatrix{<:Any,LL,UU,<:BlockRange1,<:BlockIndexRange1}) where {LL,UU} =
(1,parent(V).block_sizes.block_strides[Int(Block(parentindices(V)[2]))])

function Base.cconvert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,<:BlockRange1,<:BlockIndexRange1}) where {T,LL,UU}
V
end
function unsafe_convert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,<:BlockRange1,<:BlockIndexRange1}) where {T,LL,UU}
A = parent(V)
JR = parentindices(V)[2]
Expand All @@ -127,6 +133,9 @@ function unsafe_convert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,<:Block
p + sizeof(T)*(JR.block.indices[1][1]-1)*stride(V,2)
end

function Base.cconvert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,BlockIndexRange1,BlockIndexRange1}) where {T,LL,UU}
V
end
function unsafe_convert(::Type{Ptr{T}}, V::SubBlockSkylineMatrix{T,LL,UU,BlockIndexRange1,BlockIndexRange1}) where {T,LL,UU}
A = parent(V)
JR = parentindices(V)[2]
Expand Down
Loading