Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 6 6
Lines 235 235
=======================================
Hits 234 234
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Re the changelog, given that we haven't released anything yet I don't think it is that helpful to update this, so if you are okay with it I would just keep this for now. |
kellertuer
approved these changes
Apr 30, 2026
Member
kellertuer
left a comment
There was a problem hiding this comment.
Sure, the Changelog can be ignored here. It is really just to later have in mind that at least one itemise point per PR would be nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor change to alter the tests to use the ParallelTestRunner.jl interface.
To make this work, I also had to update the printing machinery slightly, since
string(x)does not now about the context, so it would print types as if they are shown in theMainmodule, which doesn't necessarily haveAlgorithmsInterfaceloaded.This became visible here since ParallelTestRunner starts new processes to really isolate the tests, therefore you can't really control what is visible in
Main(and@eval Main using AlgorithmsInterfacefeels very wrong 😉 )Let me know if the explanation is clear enough, I'm happy to include a small readme file in the tests as well if you think that could be helpful