-
Notifications
You must be signed in to change notification settings - Fork 1
Start with the main types #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
9974d5b
Start defining main types
kellertuer 6aff115
Setup docs and first actions.
kellertuer 0231074
Setup tests.
kellertuer 3239f6f
Start with stopping criteria.
kellertuer 6106ce7
First steps towards stopping criterion.
kellertuer 555eecb
Further on SC.
kellertuer fcdc02f
Towards the first plain interface.
kellertuer 5c9b76f
fix compat.
kellertuer 8bc978a
Fix make.jl
kellertuer 64e98f9
Update docs/make.jl
kellertuer 450cd2c
Fix an emoji typo.
kellertuer e6b4b99
update README.
kellertuer 46f4ba6
Small typo
lkdvos 2dab83b
Add simple test
lkdvos 5ec3915
Actually run tests
lkdvos 6e681e3
return `state`
lkdvos 8115f5e
Start redesign
kellertuer 8958870
Merge branch 'kellertuer/main-types' of github.com:JuliaManifolds/Alg…
kellertuer d4c9948
finish redesign.
kellertuer 651577a
Implement most of StopWhenAny and StopWhenAll and their |, & operations.
kellertuer dff8c74
Update src/stopping_criterion.jl
kellertuer ba7bc85
Apply suggestions from code review
kellertuer 0e98869
Update src/stopping_criterion.jl
kellertuer 83b44ee
Update src/stopping_criterion.jl
kellertuer 3ce717f
Update src/stopping_criterion.jl
kellertuer badca09
Update src/stopping_criterion.jl
kellertuer 3460c22
Update src/stopping_criterion.jl
kellertuer 1aeb445
A few points from the discussions
kellertuer 7aa39b7
add context.
kellertuer 6bb3f18
Refactor interface to have `problem, algorithm, state`
lkdvos 2637011
longer argument names
lkdvos 52ad3e9
Small fixes and adapt tests
lkdvos 8d2ef32
Formatter
lkdvos a2dc6c2
refatctor stopping criterion and is_finished.
kellertuer 8b18564
Update src/stopping_criterion.jl
kellertuer c2db111
Replace `get_` with `getproperty`
lkdvos 1d88373
remove some intermediate buffers
lkdvos 692bc44
fix typo
lkdvos 0b4d003
Apply suggestions from formatter
lkdvos 3380089
Fix indentation
lkdvos b29c16d
Merge branch 'kellertuer/main-types' of https://github.com/JuliaManif…
lkdvos 965ac50
Add Aqua tests
lkdvos d2e9b12
remove manifest from git
lkdvos f8260dc
Add missing compat entry
lkdvos 9be623d
Fix exports
lkdvos 2b776d0
Add readme badges
lkdvos b467400
Add missing supertype
lkdvos 38dba58
Add some tests for stopping criteria
lkdvos 2ed240b
fix tests
lkdvos a087e62
Apply suggestions from code review
lkdvos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: CompatHelper | ||
| on: | ||
| schedule: | ||
| - cron: 0 0 * * * | ||
| workflow_dispatch: | ||
| jobs: | ||
| CompatHelper: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Install CompatHelper" | ||
| run: | | ||
| import Pkg | ||
| name = "CompatHelper" | ||
| uuid = "aa819f21-2bde-4658-8897-bab36330d9b7" | ||
| version = "3" | ||
| Pkg.add(; name, uuid, version) | ||
| shell: julia --color=yes {0} | ||
| - name: "Run CompatHelper" | ||
| run: | | ||
| import CompatHelper | ||
| CompatHelper.main() | ||
| shell: julia --color=yes {0} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: TagBot | ||
| on: | ||
| issue_comment: | ||
| types: | ||
| - created | ||
| workflow_dispatch: | ||
| jobs: | ||
| TagBot: | ||
| if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: JuliaRegistries/TagBot@v1 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| ssh: ${{ secrets.DOCUMENTER_KEY }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: CI | ||
| on: | ||
| push: | ||
| branches: [master] | ||
| tags: [v*] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Julia ${{ matrix.julia-version }}–${{ matrix.os }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| matrix: | ||
| julia-version: ["lts", "1", "pre"] | ||
| os: [ubuntu-latest, macOS-latest] | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: ${{ matrix.julia-version }} | ||
| arch: x64 | ||
| - uses: julia-actions/cache@v2 | ||
| - uses: julia-actions/julia-buildpkg@latest | ||
| - uses: julia-actions/julia-runtest@latest | ||
| env: | ||
| PYTHON: "" | ||
| - uses: julia-actions/julia-processcoverage@v1 | ||
| - uses: codecov/codecov-action@v5 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| file: ./lcov.info | ||
| name: codecov-umbrella | ||
| fail_ci_if_error: false | ||
| if: ${{ matrix.os =='ubuntu-latest' }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Doc Preview Cleanup | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
|
|
||
| jobs: | ||
| doc-preview-cleanup: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout gh-pages branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: gh-pages | ||
| - name: Delete preview and history + push changes | ||
| run: | | ||
| if [ -d "previews/PR$PRNUM" ]; then | ||
| git config user.name "Documenter.jl" | ||
| git config user.email "documenter@juliadocs.github.io" | ||
| git rm -rf "previews/PR$PRNUM" | ||
| git commit -m "delete preview" | ||
| git branch gh-pages-new $(echo "delete history" | git commit-tree HEAD^{tree}) | ||
| git push --force origin gh-pages-new:gh-pages | ||
| fi | ||
| env: | ||
| PRNUM: ${{ github.event.number }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: Documenter | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| tags: [v*] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| docs: | ||
| name: Documentation | ||
| runs-on: ubuntu-latest | ||
| # if: contains( github.event.pull_request.labels.*.name, 'preview docs') || github.ref == 'refs/heads/master' || contains(github.ref, 'refs/tags/') | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| # - uses: quarto-dev/quarto-actions/setup@v2 | ||
| # with: | ||
| # version: "1.6.38" | ||
| - uses: julia-actions/setup-julia@latest | ||
| with: | ||
| version: "1.11" | ||
| - name: Julia Cache | ||
| uses: julia-actions/cache@v2 | ||
| # - name: Cache Quarto | ||
| # id: cache-quarto | ||
| # uses: actions/cache@v4 | ||
| # env: | ||
| # cache-name: cache-quarto | ||
| # with: | ||
| # path: tutorials/_freeze | ||
| # key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('tutorials/*.qmd') }} | ||
| # restore-keys: | | ||
| # ${{ runner.os }}-${{ env.cache-name }}- | ||
| # - name: Cache Documenter | ||
| # id: cache-documenter | ||
| # uses: actions/cache@v4 | ||
| # env: | ||
| # cache-name: cache-documenter | ||
| # with: | ||
| # path: docs/src/tutorials | ||
| # key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('tutorials/*.qmd') }} | ||
| # restore-keys: | | ||
| # ${{ runner.os }}-${{ env.cache-name }}- | ||
| # - name: Cache CondaPkg | ||
| # id: cache-condaPkg | ||
| # uses: actions/cache@v4 | ||
| # env: | ||
| # cache-name: cache-condapkg | ||
| # with: | ||
| # path: docs/.CondaPkg | ||
| # key: ${{ runner.os }}-${{ env.cache-name }}-${{ hashFiles('docs/CondaPkg.toml') }} | ||
| # restore-keys: | | ||
| # ${{ runner.os }}-${{ env.cache-name }}- | ||
| - name: "Documenter rendering" | ||
| run: "docs/make.jl --quarto" | ||
| env: | ||
| PYTHON: "" | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }} | ||
| # note: | ||
| # name: "Documentation deployment note." | ||
| # runs-on: ubuntu-latest | ||
| # if: "!contains( github.event.pull_request.labels.*.name, 'preview docs')" | ||
| # steps: | ||
| # - name: echo instructions | ||
| # run: echo 'The Documentation is only generated and pushed on a PR if the “preview docs” label is added.' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Format | ||
| on: | ||
| push: | ||
| branches: [master] | ||
| tags: [v*] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| format: | ||
| name: "Format Check" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: 1 | ||
| - uses: julia-actions/cache@v2 | ||
| - name: Install JuliaFormatter and format | ||
| run: | | ||
| using Pkg | ||
| Pkg.add(PackageSpec(name="JuliaFormatter", version="1")) | ||
| using JuliaFormatter | ||
| format("."; verbose=true) | ||
| shell: julia --color=yes {0} | ||
| - name: Suggest formatting changes | ||
| uses: reviewdog/action-suggester@v1 | ||
| if: github.event_name == 'pull_request' | ||
| with: | ||
| tool_name: JuliaFormatter | ||
| fail_on_error: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| docs/build | ||
| docs/Manifest.toml | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # This file is machine-generated - editing it directly is not advised | ||
|
|
||
| julia_version = "1.11.4" | ||
| manifest_format = "2.0" | ||
| project_hash = "95f2e526c8800bfc6b50be6b2a71dba6d896214b" | ||
|
|
||
| [[deps.Dates]] | ||
| deps = ["Printf"] | ||
| uuid = "ade2ca70-3891-5945-98fb-dc099432e06a" | ||
| version = "1.11.0" | ||
|
|
||
| [[deps.Printf]] | ||
| deps = ["Unicode"] | ||
| uuid = "de0858da-6303-5e67-8744-51eddeeeb8d7" | ||
| version = "1.11.0" | ||
|
|
||
| [[deps.Unicode]] | ||
| uuid = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5" | ||
| version = "1.11.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,16 @@ | ||
| name = "AlgorithmInterface" | ||
| uuid = "125df6b2-f2b1-44d3-9e4a-6c50c163a640" | ||
| name = "AlgorithmsInterface" | ||
| uuid = "d1e3940c-cd12-4505-8585-b0a4b322527d" | ||
| authors = ["Ronny Bergmann <git@ronnybergmann.net>"] | ||
| version = "0.1.0" | ||
|
|
||
| [deps] | ||
| Dates = "ade2ca70-3891-5945-98fb-dc099432e06a" | ||
|
|
||
| [compat] | ||
| Dates = "1.10" | ||
| julia = "1.10" | ||
| [extras] | ||
| Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
|
||
| [targets] | ||
| test = ["Test"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [deps] | ||
| AlgorithmsInterface = "d1e3940c-cd12-4505-8585-b0a4b322527d" | ||
| Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" | ||
| DocumenterCitations = "daee34ce-89f3-4625-b898-19384cb65244" | ||
| DocumenterInterLinks = "d12716ef-a0f6-4df4-a9f1-a5a34e75c656" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| #!/usr/bin/env julia | ||
| # | ||
| # | ||
|
|
||
| if "--help" ∈ ARGS | ||
| println(""" | ||
| docs/make.jl | ||
|
|
||
| Render the `AlgorithmsInterface.jl` documentation with optional arguments | ||
|
|
||
| Arguments | ||
| * `--help` print this help and exit without rendering the documentation | ||
| * `--prettyurls` toggle the pretty urls part to true, which is always set on CI | ||
| """) | ||
| exit(0) | ||
| end | ||
|
|
||
| using Pkg | ||
| Pkg.activate(@__DIR__) | ||
| Pkg.develop(PackageSpec(; path = (@__DIR__) * "/../")) | ||
| Pkg.resolve() | ||
| Pkg.instantiate() | ||
|
|
||
| using Documenter, DocumenterCitations, DocumenterInterLinks | ||
| using AlgorithmsInterface | ||
|
|
||
| run_on_CI = (get(ENV, "CI", nothing) == "true") | ||
|
|
||
| bib = CitationBibliography(joinpath(@__DIR__, "src", "references.bib"); style = :alpha) | ||
| links = InterLinks() | ||
| makedocs(; | ||
| format = Documenter.HTML(; | ||
| prettyurls = run_on_CI || ("--prettyurls" ∈ ARGS), | ||
| assets = [ | ||
| # "assets/favicon.ico", | ||
| "assets/citations.css", | ||
| "assets/link-icons.css", | ||
| ], | ||
| ), | ||
| modules = [AlgorithmsInterface], | ||
| authors = "Ronny Bergmann, Lukas Devos, and contributors.", | ||
| sitename = "AlgorithmsInterface.jl", | ||
| pages = [ | ||
| "Home" => "index.md", | ||
| "Interface" => "interface.md", | ||
| "Stopping criteria" => "stopping_criterion.md", | ||
| "References" => "references.md", | ||
| ], | ||
| plugins = [bib, links], | ||
| ) | ||
| deploydocs(; repo = "github.com/JuliaManifolds/AlgorithmsInterface.jl", push_preview = true) | ||
| #back to main env | ||
| Pkg.activate() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* Taken from https://juliadocs.org/DocumenterCitations.jl/v1.2/styling/ */ | ||
|
|
||
| .citation dl { | ||
| display: grid; | ||
| grid-template-columns: max-content auto; } | ||
| .citation dt { | ||
| grid-column-start: 1; } | ||
| .citation dd { | ||
| grid-column-start: 2; | ||
| margin-bottom: 0.75em; } | ||
| .citation ul { | ||
| padding: 0 0 2.25em 0; | ||
| margin: 0; | ||
| list-style: none;} | ||
| .citation ul li { | ||
| text-indent: -2.25em; | ||
| margin: 0.33em 0.5em 0.5em 2.25em;} | ||
| .citation ol li { | ||
| padding-left:0.75em;} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.