Skip to content

Runic formatter#6

Merged
lkdvos merged 3 commits intomainfrom
runic
Oct 16, 2025
Merged

Runic formatter#6
lkdvos merged 3 commits intomainfrom
runic

Conversation

@lkdvos
Copy link
Copy Markdown
Collaborator

@lkdvos lkdvos commented Oct 15, 2025

Just since I think we both agree, and it is nicer to have this in a separate PR from which we both can work, I'd propose to already merge this.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@1191032). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/stopping_criterion.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   45.40%           
=======================================
  Files           ?        4           
  Lines           ?      174           
  Branches        ?        0           
=======================================
  Hits            ?       79           
  Misses          ?       95           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos lkdvos requested a review from kellertuer October 15, 2025 20:40
Copy link
Copy Markdown
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@lkdvos lkdvos merged commit 4a60118 into main Oct 16, 2025
11 checks passed
@lkdvos lkdvos deleted the runic branch October 16, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants