Skip to content

Support Base.OffsetCConvert in Julia 1.14 #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eschnett wants to merge 2 commits into from
+12 −2
Closed

Support Base.OffsetCConvert in Julia 1.14 #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b42eca
Support `Base.OffsetCConvert` in Julia 1.14
eschnett Mar 10, 2026
a26c667
add an implementation note
vchuravy Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/buffers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,23 @@
MPIBuffertype{T} = Union{Ptr{T}, Array{T}, SubArray{T}, Ref{T}}
MPIBuffertypeOrConst{T} = Union{MPIBuffertype{T}, SentinelPtr}

# Implementation note
# Base.cconvert and Base.unsafe_convert are a matched pair.
# We must implement Base.unsafe_convert(MPIPtr, ::typeof(Base.cconvert(MPIPtr, x))),
# which is not possible to do generically. So we must define them as we find them.

Base.cconvert(::Type{MPIPtr}, x::Union{Ptr{T}, Array{T}, Ref{T}}) where T = Base.cconvert(Ptr{T}, x)
Base.cconvert(::Type{MPIPtr}, x::SubArray{T}) where T = Base.cconvert(Ptr{T}, x)
function Base.unsafe_convert(::Type{MPIPtr}, x::MPIBuffertype{T}) where T
ptr = Base.unsafe_convert(Ptr{T}, x)
reinterpret(MPIPtr, ptr)
end

@static if VERSION >= v"1.14.0-DEV"
function Base.unsafe_convert(::Type{MPIPtr}, x::Base.OffsetCConvert{T}) where {T}
ptr = Base.unsafe_convert(Ptr{T}, x) # Base handles offset arithmetic
reinterpret(MPIPtr, ptr)
end
end

Base.cconvert(::Type{MPIPtr}, x::String) = x
Base.unsafe_convert(::Type{MPIPtr}, x::String) = reinterpret(MPIPtr, pointer(x))
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ testfiles = sort(filter(istest, readdir(testdir)))
# test number of processes.
"JULIA_MPI_TEST_NUM_PROCESSES"=>string(n))
if f == "test_spawn.jl"
# Some command as the others, but always use a single process
# Same command as the others, but always use a single process
run(cmd(1))
elseif f == "test_threads.jl"
# Legacy Intel MPI (before 2020) crashes threads tests:
Expand Down
Loading