Leverage execution policies for LVS equivalence#2366
Open
nikosavola wants to merge 1 commit into
Open
Conversation
a66e434 to
f6a36a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2364 but for LVS: annotates the
std::sortcalls in the netlist comparer (dbNetlistCompare.cc,dbNetlistCompareCore.cc) withstd::execution::parso the large per-circuit sorts can run in parallel.Benchmark
A flat, highly-symmetric resistor mesh (
G=500→ 250k nets, 499k resistors) is built via the Ruby API and compared against an identical copy (self-compare, all runsmatched=true). The timed region iscompare()only. Baseline is a separately built serial library (=master). Using g++ 14.2, oneTBB 2022.1.compare(), vs serial)master)Pinned to one core (
taskset -c 0),paris still 1.66× over serial but I don't know why. Would need to check TBB's sorting implementation.Reproduction
Build
bin-releasewith the C++17 + TBB flags and the corrected guard, thenuv run benchmark.py. Both scripts are below.test_lvs.rb— netlist generator + self-compare (timed)benchmark.py— taskset thread sweep (isolatedcompare()+ end-to-end hyperfine)