UI node input to output edges #898#972
Merged
Merged
Conversation
The node catalog already carries the outputs a node type produces, but the editor dropped them. Surface them read-only under the parameters tree (e.g. "outputs: case, fields"). Adds a nodeOutputNames helper + tests.
Dragging from an output handle to an input handle now writes
{source.output.name} into the target node's input parameter, and
deleting the line clears that reference. Previously dataflow lines
were read-only visualizations of parameter references.
- workflowDataflow.ts: add pure helpers parseDataflowConnection,
setInputReference, parseDataflowEdgeId, clearInputReference, and
dataflowReference; extract out:/in:/df: prefixes into constants.
- WorkflowGraph.tsx: branch onConnect / onEdgesDelete / isValidConnection
on dataflow vs requires connections.
- tests: cover the new helpers, including a set → rebuild round-trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.