UI node reference outputs, resize nodes, and details-view refactor #898#975
Merged
Conversation
Break the branch actions, delete button, and empty-branch placeholder out
of DetailsViewItem so they can be reused by a future workflow-node variant
and to slim down the parent.
- DetailsViewItemBranchActions: add-item / add-sub-structure / edit-as-JSON
cluster, owns the addSubItem logic
- DeleteFieldButton: delete control, owns the setItemKey guard so callers
render it unconditionally
- EmptyBranchLabel: the "(empty)" placeholder with its indent math
No behavior change.
Replace the repeated `{menu?.kind === … && <MenuItem>}` blocks with an
`actionsFor(menu, handlers)` helper that returns the list of actions for a
target, and a single render loop that maps them to MenuItems.
- MenuAction ({ label, run, danger? }) describes one entry; `danger` drives
the red colour.
- Adding/reordering items is now one line in actionsFor, with no duplicated
label/onClick/onClose wiring.
- The switch is exhaustive over the kind enum, so a new target kind is a
compile error until handled.
No behavior change.
…menu Right-click a node input param → fly-out node autocomplete → fly-out output autocomplete; choosing an output calls onReferenceOutput and closes the cascade. Adds NodeOutputOption + referenceOptions/onReferenceOutput props and a test for the flow.
Capture the right-click caret on an input param and thread it through the
context menu; choosing a node output now splices {node.parameters.output}
into the value at that caret (via new insertReferenceAt) rather than
overwriting the whole field. Falls back to end-of-value when the click
wasn't inside the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few workflow-graph editing features and refactors the details view they build on.
#898
Features
output param" opens cascading submenus (pick a node, then its output). The
chosen {node.parameters.output} token is inserted at the caret in the
field, and a dataflow line is drawn automatically.
260×80). Size is view-only (not saved with the workflow) and survives graph
edits.
instead of per-editor.