Add ability to add more glob loads without deleting old globs by tronicboy1 · Pull Request #1045 · Keats/tera

tronicboy1 · 2026-10-07T15:58:39Z

Changes

modifies load_from_glob to be compatible with multiple glob dirs without breaking previous behavior
Ensure full_reload is compatible with multiple glob dirs
adds add_from_glob, to add multiple glob directories

… loads without deleting old

Keats · 2026-10-08T08:30:55Z

What's the usecase?
You can easily load as many as you want via load_from_glob + add template files (still need to handle your own full reload but that's not too hard either) and I haven't had this request since Tera exists so not too inclined on adding it.

tronicboy1 · 2026-10-08T14:02:02Z

I have a project that shares some templates as a base but adds more depending on which deployment it is and what features are enabled. Tera V1 supported my current project structure, now in V2 the same use of glob loading causes it to reset the previous glob load.
add_template_files would mean a lot more work of hard coding directories.

tronicboy1 · 2026-10-08T14:08:17Z

In V1, you could use Tera::extend to run glob multiple times.

// We want to preserve templates that have been added through
        // Tera::extend so we only keep those
        self.templates = self
            .templates
            .iter()
            .filter(|&(_, t)| t.from_extend)
            .map(|(n, t)| (n.clone(), t.clone())) // TODO: avoid that clone
            .collect();

This is how I used it, however in V2 Tera::extend is gone so I cannot use it the same way anymore.

Keats · 2026-10-15T12:17:28Z

I think this approach is wrong then. You can change the glob field in Tera to be a Vec and add a new fn like add_from_glob and just iterate on the glob vec for full reload? The approach in this PR is too complex and from a quick lookup it seems buggy since in full_reload in split by , but , is a valid character in a glob eg {html,css}

tronicboy1 · 2026-10-15T16:14:36Z

@Keats
Thank you for your feedback. I considered changing Tera.glob to Vec<String>. As you say that makes more sense.

I changed it here to a Vec and pushed the globs added to it.
13eadcb

By all means if you have a better/more elegant solution I would love it. I just need the ability to add multiple glob directories to restore backwards compatibility with the Tera::extend function.

I think the fact that I am implementing two features in this PR makes it seem too complicated. I am restoring the ability to extend multiple glob dirs, but also adding the ability for load_from_glob to take multiple forms of input. Would it be better to just make add_from_glob accept &str as it's input and remove the code added to globbing.rs for generics?

tronicboy1 · 2026-10-15T16:23:25Z

-        if let Some(glob) = self.glob.clone().as_ref() {
-            self.load_from_glob(glob)
+        if self.glob.len() > 0 {
+            let current_globs = self.glob.clone();


Suggested change

let current_globs = self.glob.clone();

let current_globs = std::mem::take(&mut self.glob);

We could do it this way so there is no memory alloc cost.

Keats · 2026-10-16T08:36:29Z

This is still way too complex. You can probably do it in 20 loc or something. No need to change anything to load_from_glob except pushing it into a vec for example

tronicboy1 · 2026-10-16T13:06:49Z

@Keats
I tried making it as simple as possible, preserving previous behavior while adding ability to push multiple glob dirs. What do you think?

tronicboy1 · 2026-10-26T12:09:35Z

@Keats
I fixed the clippy errors. Thank you!

Keats

Ignore the outdated comments,

Keats · 2026-10-26T21:36:58Z

+
+        // Insert globs already registered
+        for dir in self.glob.iter() {
+            all_glob_entries.extend(load_from_glob(dir)?);


this will return in case of errors before putting back the prev_templates/globs back

d900667

@Keats
I addressed this issue and restored the prev_templates functionality.

Keats · 2026-10-26T21:37:04Z

+        let is_new_and_valid = !glob.is_empty() && self.glob.insert(glob.to_string());
+
+        if is_new_and_valid {
+            all_glob_entries.extend(load_from_glob(glob)?);


same as above

5117736

@Keats
I addressed this.

Keats · 2026-10-26T21:37:59Z

    /// let mut tera = Tera::default();
    /// tera.load_from_glob("examples/basic/templates/**/*").unwrap();
+    ///
+    /// tera.load_from_glob("examples/dashboard/**/*").unwrap();


this is a breaking change, the basic load_from_glob should not change, the PR should add a function to add globs

ae21917

@Keats
I added a function add_from_glob that adds a template, and restored the previous behavior of wiping other globs to load_from_glob. I also added a test that ensures the behavior.

Keats · 2026-10-26T21:38:52Z

    /// Only used if the `glob_fs` feature is turned on
    #[allow(dead_code)]
-    pub(crate) glob: Option<String>,
+    pub(crate) glob: HashSet<String>,


It should be a Vec

@Keats
d40e081
I changed the implementation to use a Vec instead of HashMap.

…dd_from_glob to provide multiple glob registration

tronicboy1 added 6 commits October 7, 2026 11:55

Allow glob loading from slice of str and add ability to add more glob…

76438d8

… loads without deleting old

reduce repetitive documentation

7d46fc0

fix full reload functionality

0ef32c0

fix manual added templates not preserved error

9078dee

add reload test for add glob

ab7d19d

restore comment accidentally deleted

b32ecdf

use Vec<String> instead of string to avoid conflicting delimiter issue

13eadcb

tronicboy1 commented Oct 15, 2026

View reviewed changes

tronicboy1 added 2 commits October 16, 2026 08:58

simplify implementation of multiple load_from_glob

04d0c04

remove generic

9a5771a

rename variable

74906c0

tronicboy1 changed the title ~~Allow glob loading from slice of str and add ability to add more glob loads without deleting old globs~~ Add ability to add more glob loads without deleting old globs Oct 16, 2026

fix clippy errors

81bf8dc

Keats requested changes Oct 26, 2026

View reviewed changes

tronicboy1 added 4 commits October 27, 2026 08:33

use Vec instead of HashSet

d40e081

do not return on glob error

d900667

fix return before revert on existing globs

5117736

remove breaking change functionality from load_from_glob and add fn a…

ae21917

…dd_from_glob to provide multiple glob registration

tronicboy1 requested a review from Keats October 27, 2026 14:59

add glob fs feature barrier to load_glob_inner

523c89d

	let current_globs = self.glob.clone();
	let current_globs = std::mem::take(&mut self.glob);

Conversation

tronicboy1 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Keats commented Oct 8, 2026

Uh oh!

tronicboy1 commented Oct 8, 2026

Uh oh!

tronicboy1 commented Oct 8, 2026

Uh oh!

Keats commented Oct 15, 2026

Uh oh!

tronicboy1 commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keats commented Oct 16, 2026

Uh oh!

tronicboy1 commented Oct 16, 2026

Uh oh!

tronicboy1 commented Oct 26, 2026

Uh oh!

Keats left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tronicboy1 Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tronicboy1 commented Oct 7, 2026 •

edited

Loading

tronicboy1 commented Oct 15, 2026 •

edited

Loading

tronicboy1 Oct 27, 2026 •

edited

Loading