Repository navigation
Error when the safe filter receives an undefined value - #1054
Merged
Merged
Conversation
Cow<str> conversion formatted undefined as an empty string, so
{{ missing | safe }} rendered blank while {{ missing }} already
errors. Reject undefined there so string filters match the existing
undefined contract. default() still takes Value and is unchanged.
mart-e
reviewed
Oct 26, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{ missing }}already fails.{{ missing | safe }}did not: converting undefined toCow<str>formatted it as an empty string, so thesafefilter marked a blank as HTML-safe.Reject undefined in that conversion. The error is
expected string but got undefined.| default(value=...)is unchanged because it takesValue.Fixes #1050.