Repository navigation
fix: omni search with no source and hidden errors - #316
Closed
divyanshugarg36 wants to merge 1 commit into
Closed
divyanshugarg36 wants to merge 1 commit into
divyanshugarg36 wants to merge 1 commit into
Conversation
Omni search built an empty Source= filter when no source was given, which Meilisearch rejects, and the error was swallowed into an empty array. Only filter on a known source, and return a 500 when the search fails.
This was referenced Oct 23, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omni search (
searchtype=8) returned[]whenever no&source=was given.omni.jsbuilt an emptySource=filter, which Meilisearch rejects.Changes:
omni.jsfilters onSourceonly when a source is given, and rethrows errors instead of returning[].shabads.jspasses the source only if it's a known one, and returns a 500 when the omni search fails.Tested against a local Meilisearch: searches with no source return results again, and searches with a source are still filtered.
Merges cleanly with dev and with #315 (they edit different parts of
omni.js).