Adding missing data for XrGraphicsBindingOpenGLWaylandKHR#553
Open
coki04 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Adding missing data for XrGraphicsBindingOpenGLWaylandKHR#553coki04 wants to merge 1 commit intoKhronosGroup:mainfrom
coki04 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
Contributor
|
Well, that's interesting. I was pretty sure that I was told there was some fatal flaw in the Wayland bindings. Congrats! |
Collaborator
|
An issue (number 2569) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2569 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
Contributor
|
Note that the Wayland part of the OpenGL binding has been officially deprecated as unimplemented and unimplementable without flaws in 1.1.54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using GL over Wayland, the XrGraphicsBindingOpenGLWaylandKHR struct was left incomplete.
Completing it from the Window data.
Tested working correctly on Ubuntu 25.04, KDE Wayland backend after also implementing XrGraphicsBindingOpenGLWaylandKHR at Monado OpenXR runtime (Pull Request for XrGraphicsBindingOpenGLWaylandKHR at Monado in progress too)