Include <iterator> directly in api_layer_interface.cpp#554
Merged
rpavlik merged 1 commit intoKhronosGroup:mainfrom Jul 24, 2025
Merged
Include <iterator> directly in api_layer_interface.cpp#554rpavlik merged 1 commit intoKhronosGroup:mainfrom
rpavlik merged 1 commit intoKhronosGroup:mainfrom
Conversation
|
|
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 14, 2025
The new libc++ roll requires us to add a direct include to this file. Since it takes a while for upstream changes to roll in, fork the file until it's fixed upstream. The upstream change is KhronosGroup/OpenXR-SDK-Source#554 For ease of review, the patchsets in this CL are as follows: 1 - copy the file unchanged 2 - Make the change, update the patch and build files Note that the presubmit complained about formatting, but I wasn't able to get `git cl format` to actually do anything. Bug: 431755915 Change-Id: I0a42ccfbb1c95b8494d6590bf691578b82a7074a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6734768 Commit-Queue: Devon Loehr <dloehr@google.com> Auto-Submit: Devon Loehr <dloehr@google.com> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#1486440}
The newest version of LLVM's libc++ no longer includes <iterator> transitively, so we need to include it directly in order to have access to `std::back_inserter`.
Contributor
|
Thanks! |
rpavlik
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newest version of LLVM's libc++ no longer includes transitively, so we need to include it directly in order to have access to
std::back_inserter.