[hello_xr] Use preferred depth swapchain format rather than (somewhat unsupported) D32.#597
Open
emaschino wants to merge 1 commit intoKhronosGroup:mainfrom
Open
[hello_xr] Use preferred depth swapchain format rather than (somewhat unsupported) D32.#597emaschino wants to merge 1 commit intoKhronosGroup:mainfrom
emaschino wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
… unsupported) D32.
emaschino
force-pushed
the
fix/OpenXR_1.1.54
branch
from
fc5662f to
0a2d07e
Compare
Collaborator
|
An issue (number 2708) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2708 ), to facilitate working group processes. This GitHub pull request will continue to be the main site of discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since release of OpenXR 1.1.54, hello_xr example cannot run on some devices such as Microsoft HoloLens 2 HMD. Reason is that for some graphics plugins, D32 depth format is forcibly used. Microsoft HoloLens 2 HMD doesn't support such a format for depth swapchain (preferred depth format is D16 on this device). This PR proposes to make use of the preferred depth swapchain format instead of D32.