Repository navigation
test(cli): match the not-a-list error across a line wrap - #267
Merged
Merged
Conversation
test_non_list_test_file_exits_nonzero failed on macOS main CI. The error panel wraps at the terminal width, and with a long enough tmp path the line break lands inside "is not a list of test cases", so the substring check missed it. The output was right; the assert was reading the layout. It now collapses whitespace before matching. Reproduced locally by sweeping TMPDIR lengths: the old assert failed at two of five lengths, the new one passes at all five. Signed-off-by: Sean Mauk <seanmauk@krakennetworks.com>
krakennetworks
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the macOS failure on main (
test-full (macos-latest, 3.13)after #264).test_non_list_test_file_exits_nonzerochecked for a substring in the CLI error panel. The panel wraps at terminal width, so a long tmp path (macOS/private/var/folders/...) can put a line break inside the phrase. The assert now collapses whitespace first.Verified by sweeping
TMPDIRlengths 30–90: old assert failed at 2 of 5, new passes 5 of 5.🤖 Generated with Claude Code
https://claude.ai/code/session_011mUisB3VvPs3bWrsfUW2P6