Repository navigation
[Bug][Contract] RemittanceNFT Mint and AdmRemint events emit unclamped initial score #2000
Description
Issue #120
RemittanceNFT Mint and AdmRemint Events Emit Unclamped Initial Score
- Title:
[Bug][Contract] RemittanceNFT Mint and AdmRemint events emit unclamped initial score - Labels:
bug, contracts, nft, smart-contract, good first issue - Location:
contracts/remittance_nft/src/lib.rs:677-695, 771-790 - Description:
In bothRemittanceNFT::mint(line 678) andRemittanceNFT::admin_remint(line 772), the stored credit score is clamped to[300, 850]viainitial_score.clamp(Self::MIN_CREDIT_SCORE, Self::MAX_SCORE). However, the emitted events at line 694 ((Symbol::new(&env, "Mint"), user)) and line 789 ((Symbol::new(&env, "AdmRemint"), user)) publish(initial_score, recipient_commitment)using the raw unclampedinitial_scoreparameter instead ofmetadata.score. - Impact:
Ifmintoradmin_remintis called with an out-of-boundsinitial_score(e.g.,100or950), on-chain state stores300or850, while the emitted event reports100or950to off-chain indexers. - Suggested Fix:
Publish(metadata.score, recipient_commitment)instead of(initial_score, recipient_commitment)in bothmint(line 694) andadmin_remint(line 789), and add a test asserting the emitted event payload wheninitial_score < 300.
Activity
rupesh-kumar-sah commentedon Oct 18, 2026
Hi maintainers,
I reviewed "[Bug][Contract] RemittanceNFT Mint and AdmRemint events emit unclamped initial score" and have a structured approach ready for implementation:
I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.
I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.
Thank you!
Talentgift24-ux commentedon Oct 21, 2026
@Talentgift24-ux has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Talentgift24-ux to this issue.
mimi-esc commentedon Oct 21, 2026
@mimi-esc has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @mimi-esc to this issue.
Yemmy88 commentedon Oct 21, 2026
@Yemmy88 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Yemmy88 to this issue.
kanuemmanuel commentedon Oct 21, 2026
@kanuemmanuel has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @kanuemmanuel to this issue.
Topmatrixmor2014 commentedon Oct 21, 2026
@Topmatrixmor2014 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Topmatrixmor2014 to this issue.
YoungBoss04 commentedon Oct 21, 2026
@YoungBoss04 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @YoungBoss04 to this issue.
deborahogunjinmi592-byte commentedon Oct 22, 2026
@deborahogunjinmi592-byte has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @deborahogunjinmi592-byte to this issue.
Marvellous805 commentedon Oct 22, 2026
@Marvellous805 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Marvellous805 to this issue.
bamiebot-maker commentedon Oct 22, 2026
@bamiebot-maker has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @bamiebot-maker to this issue.
drips-wave commentedon Oct 22, 2026
Congratulations, @bamiebot-maker! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @bamiebot-maker: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
Merge pull request #2174 from bamiebot-maker/fix/2000-clamped-score-e…
grantfox-oss commentedon Oct 26, 2026
🎉 This issue has been marked as completed on GrantFox!
@bamiebot-maker's PR #2174 was approved and merged by @K1NGD4VID.
🏆 @bamiebot-maker: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,268 total points). Track your full progress on GrantFox.
👏 Great work, @bamiebot-maker! Keep contributing to LabsCrypt.
drips-wave commentedon Oct 26, 2026
This issue has been completed by @bamiebot-maker as part of the Stellar Wave Program's 10th Wave 🥳
😎 @bamiebot-maker: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
fix(contracts): emit clamped initial score in Mint and AdmRemint even…