Repository navigation
Surface pre-review findings — panel, chip, file-tree dots, toast count - #20
Merged
Merged
Conversation
…count Findings existed only as per-file Monaco pins after selecting the exact file; file-level findings were invisible entirely. Now: a FindingsPanel band (severity breakdown, expandable rationale, jump-to-line, file-level tag, shared dismissal with pins), an evidence-strip count chip that opens it, severity dots on file-tree rows, and 'Pre-review complete — N findings' in the toast. Advisory-only; nothing blocks (§9). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke (live dogfooding)
The pre-review pipeline worked end-to-end — findings parsed and stored — but the only surface was Monaco pins rendered per-file after selecting that exact file in the Diff tab. Nothing anywhere said findings existed; file-level findings (no line anchor) were invisible entirely. Verified with a real run: 2 warnings sat in the store while the UI showed nothing.
Fix (all display-only; advisory framing per research §3)
path:start–end, expandable rationale, jump-to-line (or afile-leveltag when unanchorable), dismiss shared with the pins, auto-expanded when a Critical exists, "advisory — never blocks" hint.Verified
tsc strict · vitest 233 (13 new) · vite build. No Rust changes; no gate/state-machine surface touched.
🤖 Generated with Claude Code