-
-
Notifications
You must be signed in to change notification settings - Fork 423
feat: support type inference for @field and @type function declarations in method overrides #3368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChouUn
wants to merge
3
commits into
LuaLS:master
Choose a base branch
from
ChouUn:fix/field-override-type-inference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−1
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
|
|
||
| -- Test @type field declaration with method override | ||
| TEST 'Buff' [[ | ||
| ---@class Buff | ||
| local mt = {} | ||
| ---@type (fun(self: Buff, target: Buff): boolean)? | ||
| mt.on_cover = nil | ||
|
|
||
| ---@class Buff.CommandAura : Buff | ||
| local tpl = {} | ||
| function tpl:on_cover(<?target?>) | ||
| return true | ||
| end | ||
| ]] | ||
|
|
||
| -- Test @field declaration with method override | ||
| TEST 'Animal' [[ | ||
| ---@class Animal | ||
| ---@field can_eat (fun(self: Animal, other: Animal): boolean)? | ||
| local base = {} | ||
|
|
||
| ---@class Dog : Animal | ||
| local dog = {} | ||
| function dog:can_eat(<?other?>) | ||
| return true | ||
| end | ||
| ]] | ||
|
|
||
| -- Test optional method with @type | ||
| TEST 'string' [[ | ||
| ---@class Base | ||
| local base = {} | ||
| ---@type (fun(self: Base, x: string): number)? | ||
| base.callback = nil | ||
|
|
||
| ---@class Child : Base | ||
| local child = {} | ||
| function child:callback(<?x?>) | ||
| return 1 | ||
| end | ||
| ]] | ||
|
|
||
| -- Test non-optional @field | ||
| TEST 'number' [[ | ||
| ---@class Handler | ||
| ---@field process fun(self: Handler, value: number): string | ||
| local handler = {} | ||
|
|
||
| ---@class CustomHandler : Handler | ||
| local custom = {} | ||
| function custom:process(<?value?>) | ||
| return tostring(value) | ||
| end | ||
| ]] | ||
|
|
||
| -- Test multiple parameters with @type | ||
| TEST 'string' [[ | ||
| ---@class Processor | ||
| local proc = {} | ||
| ---@type fun(self: Processor, a: number, b: string): boolean | ||
| proc.handle = nil | ||
|
|
||
| ---@class MyProcessor : Processor | ||
| local my = {} | ||
| function my:handle(a, <?b?>) | ||
| return true | ||
| end | ||
| ]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.