Skip to content

Fixed delete button#4513

Open
gabriel-bolbotina wants to merge 1 commit into
masterfrom
fix-photo-delete-button
Open

Fixed delete button#4513
gabriel-bolbotina wants to merge 1 commit into
masterfrom
fix-photo-delete-button

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Added check if the sketching controller is available or not, which fixes:

  • the broken delete button when photo sketching is not selected
  • reappearing sketches when deleting a photo with sketches and re-adding it in the project.

UI changes:

https://github.com/user-attachments/assets/3b4772aa-a900-49e5-a2b7-21317ec761e1
https://github.com/user-attachments/assets/28724eb1-1c9f-4498-bcd1-f333ad2adac7

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Coverage Report for CI Build 26822777867

Warning

No base build found for commit 93fb13e on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.928%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15231
Covered Lines: 8823
Line Coverage: 57.93%
Coverage Strength: 99.02 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68651 dmg Expires: 20/08/2026 #6865
linux Build 📬 Mergin Maps 68851 x86_64 Expires: 20/08/2026 #6885
win64 Build 📬 Mergin Maps 60591 win64 Expires: 20/08/2026 #6059
Android Build 📬 Mergin Maps 817511 APK [armeabi-v7a] Expires: 20/08/2026 #8175
📬 Mergin Maps 817511 APK [armeabi-v7a] Google Play Store #8175
Android Build 📬 Mergin Maps 817551 APK [arm64-v8a] Expires: 20/08/2026 #8175
📬 Mergin Maps 817551 APK [arm64-v8a] Google Play Store #8175
iOS Build Build failed or not found. #9117

@gabriel-bolbotina gabriel-bolbotina force-pushed the fix-photo-delete-button branch from 9c460c6 to 0681cd8 Compare June 2, 2026 13:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68771 dmg Expires: 31/08/2026 #6877
linux Build 📬 Mergin Maps 69031 x86_64 Expires: 31/08/2026 #6903
win64 Build 📬 Mergin Maps 60711 win64 Expires: 31/08/2026 #6071
Android Build 📬 Mergin Maps 818711 APK [armeabi-v7a] Expires: 31/08/2026 #8187
📬 Mergin Maps 818711 APK [armeabi-v7a] Google Play Store #8187
Android Build 📬 Mergin Maps 818751 APK [arm64-v8a] Expires: 31/08/2026 #8187
📬 Mergin Maps 818751 APK [arm64-v8a] Google Play Store #8187
iOS Build 📬 Build number: 26.06.912911 #9129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant