Repository navigation
data: price 40 tradeable quest items from ChromieCraft - #47
Merged
Merged
Conversation
The backfill candidate query excludes class 12 and 13, so quest class tradeables never got an override, and with neither a BuyPrice nor a SellPrice in item_template the bot could not list or buy them at all. 419 items across all classes were in that state. 258 have no ChromieCraft data, 9 are stale and 112 rest on one or two listings, which is where the troll prices live: item 4098 came back at 20000 gold from a single listing. Requiring three listings leaves 40 rows, Snickerfang Jowl and the Un'Goro power crystals through to Damaged Necklace at 108 gold. The per item listing counts behind the cut are in tools/price-backfill/reports/item-counts-quest-gap-2026-09-20.csv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
tools/price-backfill/reports/item-counts-quest-gap-2026-09-20.csv.Issues Addressed:
SOURCE:
419 items on the realm have neither a price override nor a BuyPrice or SellPrice in
item_template, counting only items that are tradeable (bonding IN (0,2,3),Quality <= 5) and not inmod_auctionhousebot_disabled_items. Class 12 accounts for 176 of them and class 13 for 23, because the backfill candidate query in the tool README excludes both classes. Until #44 the seller dropped every one of them at the bins filter regardless of pricing.A run over all 419 returns data for 161. The cut here is three listings rather than the default one, which is where the single-listing troll prices sit: item 4098 came back at 20000 gold, item 5052 at 10000 gold, both from one listing. That leaves 40 rows between 970 copper (Rune of Opening) and 185 gold (Waterlogged Recipe).
The remaining 379 keep the module's fallback pricing, which for these items means none at all. They are worth revisiting once ChromieCraft has more listings for them; the report file lists what each one currently has.
Depends on #46 for the fetcher, without which the run returns nothing.
Tests Performed:
How to Test the Changes:
SELECT * FROM mod_auctionhousebot_auction_history WHERE item_id = 11754.