feat: add transaction data property useMoneyAccount#8858
Open
jpuri wants to merge 3 commits into
Open
Conversation
jpuri
commented
May 20, 2026
| transactionData.isPolymarketDepositWallet = | ||
| config.isPolymarketDepositWallet; | ||
| transactionData.refundTo = config.refundTo; | ||
| transactionData.useMoneyAccount = config.useMoneyAccount; |
Contributor
Author
There was a problem hiding this comment.
Money account will be source or target depending on postQuote value.
matthewwalsh0
requested changes
May 20, 2026
| accountOverride?: Hex; | ||
|
|
||
| /** Whether to use the Money Account (Money Keyring) as the payment source. */ | ||
| useMoneyAccount?: boolean; |
Member
There was a problem hiding this comment.
Can we match the other existing configs so isMoneyAccountSource as we'll also likely need isMoneyAccountTarget in future too?
And should we add the callback at the same time so getMoneyAccountWithdrawData to the constructor?
Contributor
Author
There was a problem hiding this comment.
May be I change is to isUsingMoneyAccount , We can find source / target depending on postQuote.
I plan to work on separate PR to implement rest of changes, with this PR my intent is to unblock UI work.
On client side we need to know isUsingMoneyAccount value to set pay token and changes on review page also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add transactionData property useMoneyAccount, it will enable to know if source / target of transaction is money account.
References
Related to https://consensyssoftware.atlassian.net/browse/CONF-1409
Checklist
Note
Medium Risk
Adds a new configuration/state flag to
TransactionPayController's public types and config update path, which may require downstream consumers to handle the new field. Runtime behavior change is minimal (state propagation only).Overview
Adds a new optional
useMoneyAccountflag toTransactionConfigandTransactionDataso callers can persist whether a transaction should use the Money Account as the payment source.setTransactionConfignow reads/writes this flag into per-transaction state, with a new unit test covering the state update, and the package changelog is updated accordingly.Reviewed by Cursor Bugbot for commit 7a23a0e. Bugbot is set up for automated code reviews on this repo. Configure here.