refactor: update notification services to use AUS preferences for feature announcements#8861
Merged
samir-acle merged 2 commits intoMay 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Related PR discussion: MetaMask/metamask-mobile#30106 (comment)
References
Fixes: https://consensyssoftware.atlassian.net/browse/GE-244
Checklist
Note
Medium Risk
Changes the gating logic for fetching feature-announcement notifications to rely on AUS
marketing.inAppNotificationsEnabled, which could alter when users see announcements if preferences are missing or inconsistent. Scope is limited to notification fetching behavior and associated tests/changelog updates.Overview
Feature announcement fetching in
fetchAndUpdateMetamaskNotificationsnow depends on AUS notification preferences (marketing.inAppNotificationsEnabled) rather than the controller’sisFeatureAnnouncementsEnabledstate, and it reuses a single preferences read for both announcements and on-chain notification address selection.Tests were updated to mock AUS marketing preference and assert announcements are fetched/not fetched accordingly, and the changelog documents the switch away from the deprecated controller flag.
Reviewed by Cursor Bugbot for commit 3bb79b1. Bugbot is set up for automated code reviews on this repo. Configure here.