Repository navigation
fix(playback): recover audio streams with updated InnerTubeX - #4522
brandonp2412 wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Retain the bounded low-quality client recovery from #4522 when excluded clients leave no playable alternative. Preserve cancellation, network and restriction errors, and normal playback quality. Cover recovery boundaries and hosted cipher compatibility, including IAS player selection and Math.pow deciphering. The cipher regression fails with v0.11.0 and passes with v0.11.2. Supersedes #4522. Co-authored-by: Brandon Dick <brandon@presley.nz>
|
Superseded by e6fea3b on main. Thanks @brandonp2412; your bounded low-quality client recovery and tests were retained, with Co-authored-by credit in the commit. Reviewed the InnerTubeX v0.11.1/v0.11.2 changelogs and source changes. Added coverage for cancellation, restriction errors, exhausted fallback, and hosted cipher compatibility (IAS selection, signature/n deciphering with Math.pow). The cipher regression fails with v0.11.0 and passes with v0.11.2. Verification: FOSS debug APK built; 207 app tests and 37 InnerTube tests passed; GMS and Izzy Kotlin compilation passed. Hosted dependencies resolve InnerTubeX v0.11.2 and QuackJS 0.1.2. A separate main commit fixes pre-existing duplicate localized Discord resources that blocked the build, preserving the canonical translations. No device or live authenticated WEB_REMIX playback testing was performed in this follow-up; those end-to-end checks remain unverified. |
Summary
Reproduction
Samsung Galaxy S25 (Android 17), MetroList 13.7.0 (153),
u4HQevc9JE0(Cannons, Fire for You): two observed fetch attempts repeatedly failed withEjsChallengeSolver: QuickJsException,solved=0, andusableAudio=0, ultimately reportingStreamResolveException: No playable stream found for this track.Verification
:app:testFossDebugUnitTest— 204 tests passed, 0 failures.:app:assembleFossDebug— successful.VISIONOSstream and Media3PLAYINGstate; repeated launch logged playback success. Uninstalled only the temporary debug package afterward.Remaining limitation
The actual authenticated
WEB_REMIXsignature-deciphering path was not forced in an end-to-end test; the patched build succeeded using aVISIONOSdirect stream. Keep as draft until that path or a release-profile install is verified.