Repository navigation
docs: highlight routing and previews with a new app icon - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Both READMEs now lead with the app's two main workflows: open a 3MF in the right slicer, and preview its build plate before opening it. The existing preview gallery follows the animated routing demo, with separate captions for painted colours and multi-plate projects.
Adds an original macOS app icon, displayed in the README and bundled by both the Xcode and native build paths. The PNG master and multi-resolution ICNS are included.
Why
Finder thumbnails and Quick Look are a primary feature, but their demos were below several routing sections. Visitors should see both main capabilities before the configuration details.
How it was checked
CFBundleIconFileand byte-identicalAppIcon.icns; ICNS structure and size representations validated.git diff --checkpassed./Applicationson the existing test Mac; 39 local tests passed with zero failures. Verified the 3MF default handler, macOS-resolved app icon, enabled Quick Look extensions, configured routing decisions and a 512px thumbnail returned by the macOS thumbnail service.Notes for the reviewer
The existing synthetic preview images are reused unchanged. No new screenshots or recordings were captured. Review the rendered English and Portuguese READMEs and the icon assets directly.
This change affects documentation and app-icon packaging. It does not modify routing, thumbnail rendering, signing requirements or permissions. The app was rebuilt and installed as an upgrade on the existing test Mac. A clean first-install permission flow and an interactive Finder/Quick Look walkthrough were not tested in this pass. The Xcode build process stalled locally; the supported native build completed the local tests and installation. PR CI passed with Xcode.
Known background limitation confirmed after installation: the registered indexer returned
78: EX_CONFIGwhen started and did not write a new worker log entry. On-demand thumbnail generation passed independently. Background startup remains experimental in ad-hoc builds, as documented in both READMEs; this PR does not resolve that existing issue.