Repository navigation
feat: route G-code and brand Finder file icons - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Routes
.gcodethrough the generating slicer, with confirmed per-file choices and explicit printer mappings taking priority. Making the Router the default now covers both.3mfand.gcode. Small Finder icons retain the Router logo and identify the selected slicer with a coloured outline and letter marker.Both READMEs now start with a prominent DMG download card, clear macOS requirements and installation instructions for people who do not build software.
Why
G-code previews existed, but the app did not claim G-code as an openable document or set its default handler. Small file icons could remain generic or show only another slicer's app icon.
How it was checked
git diff --checkpassed.75f5166, including build, tests and downloadable-package verification.Notes for the reviewer
Screenshots show the same six synthetic files. macOS also gives custom file icons priority in Finder's icon view; press Space for the model in Quick Look. The README states this behaviour. Before/after screenshots cover file icons, not a clean-Mac installation or physical printing.
The app remains ad-hoc signed and unnotarized. A clean-Mac installation is not claimed. Existing personal custom icons are preserved. No printer job is sent or G-code executed; only synthetic files are used for validation.