Skip to content

fix: tint the whole Router logo with the destination colour - #5

Merged
MoraesGil merged 3 commits into
mainfrom
codex/tint-router-logo
Nov 13, 2026
Merged

MoraesGil merged 3 commits into
mainfrom
codex/tint-router-logo

Conversation

@MoraesGil

@MoraesGil MoraesGil commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

What changes

Tints the entire Router logo and its outline with the destination slicer's colour. Removes the small letter badge and gives the logo more space at Finder icon sizes. A .3mf and a .gcode with the same resolved destination use the same colour.

Existing Router icons from 1.5.0 refresh to the new design. Personal custom icons remain protected. Snapmaker Orca uses its installed black-and-white identity; Elegoo uses blue instead of pink.

Why

The previous design kept the logo green and blue and relied on a small coloured letter badge. That badge was hard to read in Finder and did not apply the destination colour to the logo itself.

How it was checked

  • Universal native Release build and 67 tests passed, including logo interior colour at 16/32/64 px, monochrome output, 1.5.0 icon migration, document bytes/dates and equal destination styles for 3MF/G-code.
  • Static review found no blocking issue; git diff --check passed.
  • PR CI passed on f4045f5, including the Xcode build, tests and downloadable-package verification.
  • DMG mounted read-only and compared with ZIP: 1.5.1, arm64 + x86_64, strict signatures and SHA256 checksums.
  • Finder before/after check with the same six synthetic files and crop. All six retained their original SHA256 and nanosecond modification dates after icon migration.

Notes for the reviewer

Before After
Finder 1.5.0: small badges and a green-blue Router logo Finder 1.5.1: full destination-colour Router logos with no badges

No routing precedence changes. Finder's icon view uses the custom logo; Space opens the model or toolpath in Quick Look. The release remains ad-hoc signed and unnotarized. No printer job is sent.

@MoraesGil MoraesGil added the bug Something isn't working label Nov 13, 2026
@MoraesGil
MoraesGil marked this pull request as ready for review November 13, 2026 05:21
@MoraesGil
MoraesGil merged commit 249d8af into main Nov 13, 2026
1 check passed
@MoraesGil
MoraesGil deleted the codex/tint-router-logo branch November 13, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant