Repository navigation
fix: tint the whole Router logo with the destination colour - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Tints the entire Router logo and its outline with the destination slicer's colour. Removes the small letter badge and gives the logo more space at Finder icon sizes. A
.3mfand a.gcodewith the same resolved destination use the same colour.Existing Router icons from 1.5.0 refresh to the new design. Personal custom icons remain protected. Snapmaker Orca uses its installed black-and-white identity; Elegoo uses blue instead of pink.
Why
The previous design kept the logo green and blue and relied on a small coloured letter badge. That badge was hard to read in Finder and did not apply the destination colour to the logo itself.
How it was checked
git diff --checkpassed.f4045f5, including the Xcode build, tests and downloadable-package verification.Notes for the reviewer
No routing precedence changes. Finder's icon view uses the custom logo; Space opens the model or toolpath in Quick Look. The release remains ad-hoc signed and unnotarized. No printer job is sent.