Repository navigation
fix: gate background preview rendering on system resources - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Finder and the background indexer share one nonblocking slot for heavy 3MF and G-code geometry work. They check host CPU and GPU usage before starting and at checkpoints during long mesh and toolpath reads. Busy Quick Look requests can display a cached or embedded image. The indexer retries deferred geometry on a later eligible pass.
Why
A two-second sample of the installed preview extension showed six concurrent panorama requests inside the XML mesh parser. Painted triangle parsing repeatedly copied Swift array storage.
How it was checked
Notes for the reviewer
Both measured loads must be below 30%. The memory admission estimate must leave 25% available. Serious thermal state and Low Power Mode block geometry. If a GPU counter is unavailable, three minutes of user inactivity is also required. The optional unattended indexer retains its AC and idle checks. These are admission thresholds with cooperative rechecks, not instantaneous hardware quotas.
The final native XCTest run passed all 71 tests. A standalone macOS probe signed with the preview extension’s sandbox entitlements acquired the shared slot, rejected an overlapping acquisition and reacquired it after release. Both extensions receive write access to a single empty lock file in the user’s Application Support directory. Finder interaction under load has not been visually recorded.