Repository navigation
Project overview: right-click a recent dialogue to export or delete it - #35
Merged
Merged
Conversation
The Dialogues tab cards have a context menu; the recent dialogues on the project overview did not. Move the menu into DialogueContextMenu and use it in both places. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U2LYX8SVLgzrkJt4GiVG1P
✅ Deploy Preview for mountea-dialoguer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cards in the Dialogues tab have a right-click menu (Export, Delete); the recent dialogues listed on the project overview did not.
DialogueContextMenucomponent that holds the menu and its handlers (same confirmation text as before).DialogueCardand the overview list both use it, so the two stay identical.Tests:
tests/e2e/dialogue-context-menu.spec.js(2 tests): cancelling the confirmation keeps the dialogue, confirming removes it from the overview; the Dialogues tab menu still works. The first test fails without the change. The library, product, domain, editor and sync regression specs pass. The only failures seen arelocalization-regressionsISS-017 andproduct-regressionsoffline onboarding, which also fail on an untoucheddevin the sandbox where this was tested.Re-checked locally on macOS against
devat29fb8c9:npm run linthas no errors, and bothdialogue-context-menutests pass.🤖 Generated with Claude Code