Repository navigation
Fix initialization retry and concurrent completion semantics (#85) - #98
Draft
AGiorgetti wants to merge 3 commits into
Draft
AGiorgetti wants to merge 3 commits into
AGiorgetti wants to merge 3 commits into
Conversation
On unchanged product code: 5 failing regressions, 1 passing idempotence test. Cover index/checkpoint setup, shared concurrent outcomes, and recursive entry. Co-authored by Alessandro Giorgetti and Codex (OpenAI).
Publish success after setup, let concurrent callers join the same attempt, and reject recursive initialization without poisoning a running attempt. Co-authored by Alessandro Giorgetti and Codex (OpenAI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Addresses #85 independently of #87 and #86, based directly on develop 286c0ae.
Tests first
The first commit, 75ddea0, contains only permanent regression tests.
Against unchanged product code on MongoDB 7.0.45 / net8.0: 5 failed, 1 passed, 0 skipped.
Six scenarios cover real index-conflict retry, checkpoint-constructor failure after indexes succeed, successful idempotence, gated concurrent success/failure, and caught recursive entry. Concurrent waiters must observe the same failed attempt rather than silently starting a retry. Tests use gates and thread state, not a timing benchmark, and follow Context/Because/Fact conventions.
The recursion regression also caught and rejected an intermediate implementation that could poison Lazy state; the final guard passes it.
Final local validation
Exact published tree: 399ca0fd95914fdfb87c57970e9223001555e90e.
Local database: MongoDB 7.0.45. MongoDB 8 cannot start on this cloud host because required /sys CPU metadata is unavailable; PR CI uses MongoDB 8. net472 was compiled, not executed on Linux. No timing benchmarks. No package, workflow or unrelated fix changes.
Exact-head GitHub CI
CI run 39969206709 succeeded on head 3fb5929: Ubuntu and Windows builds and all MongoDB 8 Linux net8.0/net9.0/net10.0 test jobs passed. No reruns were needed.
Draft for user review; do not merge or publish packages.
Co-authored by Alessandro Giorgetti and Codex (OpenAI).