Skip to content

fix: propagate async cancellation and await observer callbacks (#86) #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AGiorgetti wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix: propagate async cancellation and await observer callbacks (#86) #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
520434a
test: reproduce async cancellation and observer termination regressions
AGiorgetti Oct 23, 2026
79c751c
fix: preserve cancellation and await observer termination
AGiorgetti Oct 23, 2026
4b80aa1
docs: update changelog for #86
AGiorgetti Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# NEventStore.Persistence.MongoDB

## Unreleased

- Propagate cancellation from async operations, including snapshot writes. Observer reads still signal cancellation through `OnCompletedAsync` with the original token; terminal callbacks are now awaited, and callback outcomes reach the returned task. [#86](https://github.com/NEventStore/NEventStore.Persistence.MongoDB/issues/86)

### Breaking Changes

- Non-observer async callers must now handle `OperationCanceledException` (including `TaskCanceledException`) from operations that previously swallowed cancellation or returned success/default values; for example, `AddSnapshotAsync` now propagates cancellation instead of returning `false`. Observer reads continue to invoke `OnCompletedAsync` with the original token on cancellation, but cancellation or failure from that callback now propagates after it is awaited, without a second terminal notification. [#86](https://github.com/NEventStore/NEventStore.Persistence.MongoDB/issues/86)

## 12.1.0

- Added explicit support for net8.0, net9.0, net10.0.
Expand Down
Loading
Loading