Expose CSSOM.parse to CSSGroupingRule#113
Open
Juice10 wants to merge 1 commit into
Open
Conversation
mikaoelitiana
approved these changes
Jun 20, 2022
|
Should be merged, facing same error |
zero-t4
approved these changes
Jul 15, 2022
Author
|
@zero-t4 check out https://www.npmjs.com/package/rrweb-cssom, it has this PR merged |
|
We have also have been hitting this bug for a while now. Thankfully JSS traps it and just spits out a warning, but it'd be nice to see those warnings squashed. |
villedarony91
approved these changes
Feb 9, 2023
|
Any update on this Pull Request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CSSGroupingRule is calling CSSOM.parse but
parsewasn't included which leads to a syntax error.This PR fixes that
Line which is currently calling
CSSOM.parse:CSSOM/lib/CSSGroupingRule.js
Line 41 in a469aae