Repository navigation
fix: admit corroborated passive documentation PNG and JPEG references - #877
Open
mohgupta-ship-it wants to merge 3 commits into
Open
mohgupta-ship-it wants to merge 3 commits into
mohgupta-ship-it wants to merge 3 commits into
Conversation
From Codex: add bounded canonical source provenance for image declarations and rendered JPEGs, retaining independent threats and incomplete inspection evidence. Validate a conservative JFIF baseline subset without inspecting image semantics. Signed-off-by: Mohit Gupta <mohgupta@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Codex, prepared on Mohit Gupta’s behalf.
A valid documentation image referenced as
Asset: `assets/overview.png`.currently receives High AE1 solely because its binary contents remain unsupported. This change recognizes a narrow standalone visual-caption role and corroborates it against complete canonical source bytes, SHA256, exact position and target. It also supports a bounded baseline JFIF JPEG subset; newly admitted rendered JPEG references require the same canonical provenance. Existing rendered-PNG policy remains intact.The exception applies only to format-only reference findings. Independent executable/ambiguous uses, malformed or trailing bytes, unknown metadata, missing/mixed/fatal/truncated evidence and exhausted budgets retain their findings. Source and format proofs are cached with aggregate work limits. Image coverage stays partial: this does not perform OCR, inspect image meaning, or claim complete inspection. See the policy and supported grammar.
Validation on frozen commit
1487a18cfbb288d49ee6f1ae16df440cf916b86b:make lint,make format-check, wheel build andtwine checkpassed.partialfor all four. The hostile fixtures’ authoredincompletecompletion expectation is still a mismatch; only their security-admission expectation passes. No fixture expectation or evaluator production filtering changed.Candidate wheel SHA256:
cedf1f3db9bd9c0c0bb69ddf5dfb76833ae20934b10cc8950865f10b4d814fe1. Its package metadata inherits main’s2.12.0; this is an unreleased source candidate, not a published release or PR #852 update. Base source isdcebfa6f; main subsequently merged unrelated P2 comment-boundary changes in95a52d89with no overlapping files. Full hosted CI and Docker checks remain pending; this task ran the bounded affected tests locally.