Repository navigation
fix(oh1): recognize proven DB-API parameter binding - #890
Open
chrisknvidia wants to merge 3 commits into
Open
chrisknvidia wants to merge 3 commits into
chrisknvidia wants to merge 3 commits into
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
marked this pull request as ready for review
October 20, 2026 20:11
chrisknvidia
marked this pull request as draft
October 20, 2026 20:17
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
marked this pull request as ready for review
October 20, 2026 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888.
OH1 mistakes percent markers in literal SQL with separately bound parameters for string interpolation. Recognize bounded source-level binding through canonical
sqlite3,psycopgandpsycopg2APIs, exempting only the lexical match owned by the exact call.Check passive setup once and memoize immutable connection argument validation. Preserve whole-tree mutation/alias checks, the AST-node/depth limits and shared source-position handling. Actual interpolation, nested unsafe queries, unknown helpers, opaque/function contexts and malformed/transformed input retain findings. Runtime driver identity is not verified; scoring and exit policy are unchanged.
Validation on
8400b6c:Five hosted checks pass; hosted unit CI is still running. No live PostgreSQL, model-provider or customer production run is claimed.