Skip to content

fix(e5): distinguish proved cloud downloads from uploads - #891

Open
chrisknvidia wants to merge 3 commits into
mainfrom
feat/christopherk/e5-cloud-downloads
Open

chrisknvidia wants to merge 3 commits into
mainfrom
feat/christopherk/e5-cloud-downloads

Conversation

@chrisknvidia

@chrisknvidia chrisknvidia commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #889.

E5 treats literal cloud-to-local downloads as exfiltration and fails --fail-on-findings. Omit only individually proved AWS/GCS downloads through supported cp, non-deleting sync, or rsync forms.

Reuse the existing bounded shell helpers, consume option values with one iterator, and index only the proof's first 4,097 characters. Upload occurrences retain their locations. Moves, deletion flags, streams, dynamic operands, unknown options, compound commands and uncertain setup retain findings. SDK rules, scoring and exit policy are unchanged.

Validation on 50376f4:

  • All 87 existing focused tests pass from source and again against the installed wheel; no test files changed. Ruff, formatting and affected-module mypy pass.
  • 24 installed-console invocations and three real MCP stdio scans cover JSON/SARIF locations, strict gates, baselines, recursive reports and report files. All 127 packaged files match source, wheel and installation.
  • Repeated architecture/code/manual security review and behavior comparisons pass, including option ownership and CRLF/context-limit cases.

Local qualification is complete; hosted CI is still running. No cloud commands, model-provider calls or customer production runs were performed.

Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
@chrisknvidia
chrisknvidia marked this pull request as ready for review October 20, 2026 20:10
@chrisknvidia
chrisknvidia requested a review from rng1995 October 20, 2026 20:10
@chrisknvidia
chrisknvidia marked this pull request as draft October 20, 2026 20:17
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
@chrisknvidia
chrisknvidia marked this pull request as ready for review October 20, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E5 labels cloud-to-local downloads as cloud exfiltration

1 participant