Skip to content

Commit 5fb5593

Browse files
authored
Merge branch 'master' into nataled-patch-2-1
2 parents a0455ac + 1517c44 commit 5fb5593

2 files changed

Lines changed: 21 additions & 8 deletions

File tree

principles/fp-001-open.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ OBO Foundry ontologies are resources for the entire biological and biomedical co
1717

1818
### For ontology providers
1919

20-
OBO Foundry Ontologies MUST EITHER be released under a [Creative Commons Attribution 3.0 Unported (CC BY 3.0)](https://creativecommons.org/licenses/by/3.0/) license or later (e.g. [Attribution 4.0 International (CC BY 4.0)](https://creativecommons.org/licenses/by/4.0/), OR released into the public domain under [Creative Commons CC0 1.0 Public Domain Dedication (CC0 1.0)](https://creativecommons.org/publicdomain/zero/1.0/). The license MUST be clearly stated using the http://purl.org/dc/terms/license property followed by the URL representing the license (e.g. https://creativecommons.org/licenses/by/3.0/) in the ontology file ([OWL example](https://oboacademy.github.io/obook/reference/formatting-license/)).
20+
OBO Foundry Ontologies MUST EITHER be released under a [Creative Commons Attribution 3.0 Unported (CC BY 3.0)](https://creativecommons.org/licenses/by/3.0/) license or later (e.g. [Attribution 4.0 International (CC BY 4.0)](https://creativecommons.org/licenses/by/4.0/), OR released into the public domain under [Creative Commons CC0 1.0 Public Domain Dedication (CC0 1.0)](https://creativecommons.org/publicdomain/zero/1.0/). The license MUST be clearly stated using the [http://purl.org/dc/terms/license](http://purl.org/dc/terms/license) property followed by the URL representing the license (e.g. [https://creativecommons.org/licenses/by/3.0/](https://creativecommons.org/licenses/by/3.0/)) in the ontology file ([OWL example](https://oboacademy.github.io/obook/reference/formatting-license/)).
2121

2222
Note: CC-BY licenses allow others to distribute, remix, tweak, and build upon the work, even commercially, as long as they credit the creators for the original creation. CC0 specifies that the creators of an ontology waive, to the extent that they legally can be, all rights and place the ontology in the public domain. It does not prevent them from requesting that the ontology be properly credited and cited, but prevents any legal recourse if it is not credited. Many pros and cons of CC-BY versus CC0 are laid out in [this discussion](https://github.com/OBOFoundry/OBOFoundry.github.io/issues/285). It is important to note that one can move from CC-BY to CC0 but not the other way around.
2323

tests/test_integrity.py

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -216,17 +216,30 @@ def test_redundant_descriptions(self):
216216

217217
def test_has_purl_config(self):
218218
"""Tests that OBO PURL configuration is available."""
219+
existing_purl_configs = set()
220+
missing = set()
221+
res = requests.get('https://api.github.com/repos/OBOFoundry/purl.obolibrary.org/git/trees/master?recursive=1')
222+
self.assertEqual(
223+
200,
224+
res.status_code,
225+
"Error while fetching Git tree for OBOFoundry/purl.obolibrary.org"
226+
)
227+
data = res.json()
228+
for entry in data['tree']:
229+
if entry['path'].startswith('config/'):
230+
existing_purl_configs.add(entry['path'])
219231
for prefix, record in self.ontologies.items():
220232
if self.skip_inactive(record):
221233
continue
222234
with self.subTest(prefix=prefix):
223-
url = f"https://raw.githubusercontent.com/OBOFoundry/purl.obolibrary.org/master/config/{prefix}.yml"
224-
res = requests.get(url)
225-
self.assertEqual(
226-
200,
227-
res.status_code,
228-
msg=f"PURL configuration is missing for {prefix}",
229-
)
235+
filename = f"config/{prefix}.yml"
236+
if filename not in existing_purl_configs:
237+
missing.add(prefix)
238+
self.assertEqual(
239+
set(),
240+
missing,
241+
msg=f"PURL configuration missing for {', '.join(missing)}"
242+
)
230243

231244

232245
class TestStandardizedYaml(unittest.TestCase):

0 commit comments

Comments
 (0)