Merged
Conversation
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
reviewed
Jan 14, 2025
cmungall
requested changes
Jan 14, 2025
Contributor
cmungall
left a comment
There was a problem hiding this comment.
See comments, some minor. Overall I recommend not mixing up orthogonal file syntax issues with OMO profiles
matentzn
reviewed
Jan 20, 2025
Contributor
matentzn
left a comment
There was a problem hiding this comment.
I like this principle very much; some general feedback:
- the principle is about "term stability", yet the focus is entirely about definitions (IAO:0000115). I think the principle text should clearly refer to all ways a meaning can significantly change, including in cases where there is no human readable definition, but a rich axiomatic structure (like say in PRO or CHEBI).
- I like the concept of "referents" very much; but what I am missing here is that the source of the mapping between and ID and its referent is solely in the head of the ontology developer. So I would like the text to reflect the idea of "as intended by the ontology developer". I think this is important because the referents are never explicit, and we need to have a source of truth for who gets to define these somewhere in the text. This also helps with deciding "if the referent changed or not" - as you say, only the ontology author can decide this.
Addresses Chris M's suggestions
Addressing Nico's comments.
Contributor
Author
|
@cmungall can you verify that your concerns have been addressed? We'd like to get this moving toward public review and then implementation. |
cmungall
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.