Skip to content

New Principle 19#2668

Merged
nataled merged 14 commits intomasterfrom
nataled-patch-50
Apr 1, 2025
Merged

New Principle 19#2668
nataled merged 14 commits intomasterfrom
nataled-patch-50

Conversation

@nataled
Copy link
Copy Markdown
Contributor

@nataled nataled commented Jan 14, 2025

No description provided.

@nataled nataled added attn: Operations Committee Issues pertinent to broad Foundry activities, such as policies and guidelines principles Issues related to Foundry principles labels Jan 14, 2025
@nataled nataled self-assigned this Jan 14, 2025
Comment thread principles/fp-019-term-stability.md
Comment thread principles/fp-019-term-stability.md
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md
Copy link
Copy Markdown
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, some minor. Overall I recommend not mixing up orthogonal file syntax issues with OMO profiles

Copy link
Copy Markdown
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this principle very much; some general feedback:

  1. the principle is about "term stability", yet the focus is entirely about definitions (IAO:0000115). I think the principle text should clearly refer to all ways a meaning can significantly change, including in cases where there is no human readable definition, but a rich axiomatic structure (like say in PRO or CHEBI).
  2. I like the concept of "referents" very much; but what I am missing here is that the source of the mapping between and ID and its referent is solely in the head of the ontology developer. So I would like the text to reflect the idea of "as intended by the ontology developer". I think this is important because the referents are never explicit, and we need to have a source of truth for who gets to define these somewhere in the text. This also helps with deciding "if the referent changed or not" - as you say, only the ontology author can decide this.

@nataled nataled marked this pull request as ready for review March 5, 2025 17:45
@nataled
Copy link
Copy Markdown
Contributor Author

nataled commented Mar 11, 2025

@cmungall can you verify that your concerns have been addressed? We'd like to get this moving toward public review and then implementation.

@nataled nataled merged commit bcb6b77 into master Apr 1, 2025
5 checks passed
@nataled nataled changed the title DRAFT: New Principle 19 - for OBO Operations Review New Principle 19 - for OBO Operations Review Apr 1, 2025
@nataled nataled changed the title New Principle 19 - for OBO Operations Review New Principle 19 Apr 1, 2025
@nataled nataled deleted the nataled-patch-50 branch April 15, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attn: Operations Committee Issues pertinent to broad Foundry activities, such as policies and guidelines principles Issues related to Foundry principles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants