Skip to content

Create bmont.md#2694

Merged
deepakunni3 merged 16 commits intoOBOFoundry:masterfrom
Astghik-S:patch-1
May 6, 2025
Merged

Create bmont.md#2694
deepakunni3 merged 16 commits intoOBOFoundry:masterfrom
Astghik-S:patch-1

Conversation

@Astghik-S
Copy link
Copy Markdown
Contributor

bmont.md file added for the new accepted BMONT (Biomarker Ontology)
#2604

bmont.md file added for the new accepted BMONT (Biomarker Ontology)
@Astghik-S Astghik-S mentioned this pull request Apr 10, 2025
14 tasks
Copy link
Copy Markdown
Member

@deepakunni3 deepakunni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md
Update after the review
Modifications after the review
@Astghik-S
Copy link
Copy Markdown
Contributor Author

Dear @deepakunni3,

I addressed all your comments and made required modifications. Please let me know if anything else should be done.

Astghik-S and others added 2 commits April 24, 2025 10:24
Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
@deepakunni3 deepakunni3 self-requested a review April 25, 2025 08:02
Copy link
Copy Markdown
Member

@deepakunni3 deepakunni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Astghik-S Thank you for going through the suggestions.
Its almost there.

Just a few issues as highlighted in the PR re-review.

Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
Comment thread ontology/bmont.md Outdated
deepakunni3 and others added 5 commits April 25, 2025 10:18
Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
@deepakunni3
Copy link
Copy Markdown
Member

@akodamullil Please review the metadata for BMONT as described in the bmont.md which is part of this PR.
As the contact person for BMONT, we do need your approval to merge this PR.

Astghik-S and others added 2 commits May 3, 2025 11:52
Usage description is removed as the usage is not yet documented.

Co-authored-by: Deepak <deepakunni3@users.noreply.github.com>
bmont.obo is deleted as it is not existing.
@deepakunni3 deepakunni3 self-requested a review May 6, 2025 09:48
Copy link
Copy Markdown
Member

@deepakunni3 deepakunni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Astghik-S @akodamullil Thank you for updating the metadata and addressing the comments from the review.

This PR is good to go :)

@deepakunni3 deepakunni3 merged commit c68a17e into OBOFoundry:master May 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants