Skip to content

Improve documentation for obsoletion#2718

Merged
nataled merged 3 commits intoOBOFoundry:masterfrom
Zack-83:patch-1
May 21, 2025
Merged

Improve documentation for obsoletion#2718
nataled merged 3 commits intoOBOFoundry:masterfrom
Zack-83:patch-1

Conversation

@Zack-83
Copy link
Copy Markdown
Contributor

@Zack-83 Zack-83 commented May 20, 2025

Closes #2717

Adjust numbering, indenting and newlines; add allowed values for obsolescence reason

Closes OBOFoundry#2717 
Adjust numbering, indenting and newlines; add allowed values for obsolescence reason
@nataled nataled self-requested a review May 20, 2025 15:26
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
|obo:IAO_0000227|IAO:0000227|terms merged |???|An editor note should explain what were the merged terms and the reason for the merge. |
|obo:IAO_0000228|IAO:0000228|term imported|???|This is to be used when the original term has been replaced by a term imported from an other ontology. An editor note should indicate what is the URI of the new term to use.|
|obo:IAO_0000229|IAO:0000229|term split |???|This is to be used when a term has been split in two or more new terms. An editor note should indicate the reason for the split and indicate the URIs of the new terms created.|
|obo:OMO_0001000|OMO:0001000|out of scope |???|This obsolesence reason should be used conservatively. Typical valid examples are: un-necessary grouping classes in disease ontologies, a phenotype term added on the assumption it was a disease.|
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is highly useful--and we agree it should be documented--we don't believe it should be on this principles page since it is more detailed than we'd like. There is a page (the OBO Academy "O-book" on obsoletion) that we already reference under Implementation (first sentence below that heading) which is intended to provide such details. We will look into having this information added there and, once done, will highlight that page again under the section mentioning the obsolescence reasons. We see that the same request was made under the ontology-metadata repo, so the information won't be lost. We thus ask that the table above be removed from your suggested changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Implemented in OBOAcademy/obook#546

Comment thread principles/fp-019-term-stability.md Outdated
Comment thread principles/fp-019-term-stability.md Outdated
@nataled nataled merged commit d16c7f4 into OBOFoundry:master May 21, 2025
3 checks passed
@nataled
Copy link
Copy Markdown
Contributor

nataled commented May 21, 2025

@Zack-83 Thank you very much for your input! The html rendering is now fixed.

@Zack-83 Zack-83 deleted the patch-1 branch May 23, 2025 05:35
@Zack-83 Zack-83 restored the patch-1 branch May 23, 2025 05:54
@Zack-83
Copy link
Copy Markdown
Contributor Author

Zack-83 commented May 23, 2025

@Zack-83 Thank you very much for your input! The html rendering is now fixed.

Unfortunately that was not enough yet:

image

I added a further commit: Zack-83@f4f401e Maybe that does the job.

@nataled Maybe you can reopen the PR and execute it again, or cherry-pick the last edit

@nataled
Copy link
Copy Markdown
Contributor

nataled commented May 27, 2025

@Zack-83 it took quite a few tries, but I think we finally have the formatting correct! Thank you again for all your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation rendering in HTML: badly formatted and incomplete

2 participants