Skip to content

Update fp-019-term-stability.md#2723

Merged
nlharris merged 3 commits intomasterfrom
nataled-patch-5
May 27, 2025
Merged

Update fp-019-term-stability.md#2723
nlharris merged 3 commits intomasterfrom
nataled-patch-5

Conversation

@nataled
Copy link
Copy Markdown
Contributor

@nataled nataled commented May 27, 2025

Still trying to fix format issue.

Still trying to fix format issue.
@nataled nataled requested a review from nlharris May 27, 2025 14:59
Suggest moving problematic backticks to the end of the relevant lines.
@jamesaoverton
Copy link
Copy Markdown
Member

This is a weird one. I think the problem is the mixture of indented lists and fenced code blocks.

@nataled I made a commit that does something different but looks ok to me. What do you think?

@nataled
Copy link
Copy Markdown
Contributor Author

nataled commented May 27, 2025

@jamesaoverton if the HTML looks like the 'preview', then I do not like it. It removes a newline that, when missing, makes it more difficult to read.

Comment thread principles/fp-019-term-stability.md Outdated
```
consider: OBI:0001544
```
- OWL: Use the `oboInOwl:consider` annotation property with the value set to the full IRI(s) of the relevant term(s): `<oboInOwl:consider rdf:resource="http://purl.obolibrary.org/obo/OBI_0001544">`
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to first try the change I originally made. This change will make it harder to read.

Try again with more blank lines
Copy link
Copy Markdown
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how to review this until it is merged and I can see the final formatting.

@jamesaoverton
Copy link
Copy Markdown
Member

Ok, well here's another version, but it's impossible to get the list level for the first and second items to match if you do it this way: The fenced code block is a top-level element that will reset your list.

@nataled
Copy link
Copy Markdown
Contributor Author

nataled commented May 27, 2025

@nlharris I think we'll have to bite the bullet and approve so that we can see what changed, for better or worse, and take it from there.

@nlharris nlharris merged commit 4f36e8f into master May 27, 2025
5 checks passed
@jamesaoverton
Copy link
Copy Markdown
Member

I tested my changes locally, starting with the instructions here: https://github.com/OBOFoundry/OBOFoundry.github.io/blob/master/README-sitedev.md. They're fairly technical, and didn't work perfectly for me anyway.

We could consider using a preview tool like this one https://github.com/marketplace/actions/deploy-pr-preview but I'm not volunteering to set up and maintain that.

@nataled
Copy link
Copy Markdown
Contributor Author

nataled commented May 27, 2025

Whatever change just made DID fix the main problem. Just one more to deal with...

@nataled nataled deleted the nataled-patch-5 branch February 10, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants