reorder fields in a more logical way

[nlharris]

why did these records start with affiliation, with name buried somewhere in the middle? that makes it much tricker to correctly make edits (adding or removing someone).

i reordered the fields (with the help of a Claude-generated script) to put name first and affiliation list, in hopes of making this file more maintainable both in the short term (i need to move some members to alumni) and longer term.

lmk if anything looks wonky; i only spot-checked.

[nlharris]

i'm not sure why the tests failed - was there some sort of syntax error? (do extra spaces at the ends of lines matter?) or were the tests checking that the fields were ordered in the old way?

[jsstevenson]

I'm just eyeballing this, but I believe that the failing test checks for equality against the input YAML but it sorts the keys for each item. In other words, it checks that the input items all have alphabetically-sorted keys (which is why 'name' isn't first). Agree that this would be nice to change.

[matentzn]

We have worked a long time to standardise the metadata records to make give as little and attack surface as possible (bugs etc). So we chose to just apply alpha numerical sort ordering for everything. I think its best we keep it that way, because implementing another sort order in the QC will be very cumbersome, and the YAML files are NOT for human consumption

[nlharris]

implementing another sort order in the QC will be very cumbersome, and the YAML files are NOT for human consumption

ok, but humans are the ones who have to update this file to add/remove people, and the current weird ordering is cumbersome and error-prone for humans. i understand the reasoning, though, and will deal.

[matentzn]

You can make an issue about it, maybe I can ask someone to find a way.

[nlharris]

Closing this PR; see issue #2727