Skip to content

Update doid.md#2764

Merged
nlharris merged 10 commits intomasterfrom
lschriml-patch-2
Oct 16, 2025
Merged

Update doid.md#2764
nlharris merged 10 commits intomasterfrom
lschriml-patch-2

Conversation

@lschriml
Copy link
Copy Markdown
Contributor

@lschriml lschriml commented Sep 2, 2025

updated home page to
https://disease-ontology.org/
from
http://disease-ontology.org/
as this was not resolvable in the dashboard

updated home page to 
https://disease-ontology.org/
from 
http://disease-ontology.org/
    as this was not resolvable in the dashboard
@lschriml lschriml requested a review from nlharris September 2, 2025 14:20
Copy link
Copy Markdown
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to also fix other instances of http: in this file (e.g. DO_logo.jpg above)

@deepakunni3 deepakunni3 self-requested a review October 1, 2025 09:00
Copy link
Copy Markdown
Member

@deepakunni3 deepakunni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @nlharris is referring to the http link on Line 8, which also needs to be updated.

* Update DO logo & all URLs

* Use complete, canonical URL for disease-ontology.org
@deepakunni3 deepakunni3 self-requested a review October 14, 2025 13:03
@deepakunni3 deepakunni3 requested a review from nlharris October 14, 2025 13:25
@lschriml
Copy link
Copy Markdown
Contributor Author

Hello @nlharris -- Thank you for helping us fix these links.
Please let us know if we need any additional changes.
Cheers,
Lynn

Copy link
Copy Markdown
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to change http://www.disease-ontology.org/ to https in disdriv.md.
The other changes are all fine, though most of them were not needed.

Comment thread ontology/disdriv.md Outdated
Comment thread ontology/disdriv.md Outdated
@allenbaron
Copy link
Copy Markdown
Contributor

Sorry. This is my fault. I will work to get it fixed. disdriv.md shouldn't even be in this commit since it was dealt with in #2765.

@deepakunni3
Copy link
Copy Markdown
Member

deepakunni3 commented Oct 16, 2025

@nlharris : As @allenbaron mentioned, the https URLs for disdriv.md are fixed in master.
This PR is now only focusing on doid.md which looks good for the moment :)

@deepakunni3 deepakunni3 requested a review from nlharris October 16, 2025 15:20
@allenbaron
Copy link
Copy Markdown
Contributor

Thanks for sorting out that merge @deepakunni3. Apologies for accidentally committing some change from disdriv.md here. I guess I was juggling too many branches at the same time 😅.

@nlharris nlharris merged commit 15954a9 into master Oct 16, 2025
5 checks passed
@deepakunni3
Copy link
Copy Markdown
Member

@allenbaron All good! I thought I was seeing double with similar changes :)

Thank you @nlharris for merging the PR 👍

@deepakunni3 deepakunni3 deleted the lschriml-patch-2 branch October 17, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants